Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 729962 - dev-python/pypy3: headers install_dir is incorrect
Summary: dev-python/pypy3: headers install_dir is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-27 22:58 UTC by Tom Gillespie
Modified: 2020-06-30 18:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Gillespie 2020-06-27 22:58:15 UTC
There is an issue with the option set for headers. Specifically the line here https://github.com/gentoo/gentoo/blob/1da1f7fe7ebc3a02ada674c2a65900ed076ae0a6/dev-python/pypy3/files/7.0.0-gentoo-path.patch#L30.

When I enabled pypy3 support for pybind11 install fails due to a collision between pypy3's eval.h and pybind11's eval.h. pybind11 tries to do the right thing, but the install_dir provided for install_headers does not include the package name as it does for cpython. I don't know whether this a a pypy issue or perhaps a pybind11 issue (since pybind11 has a custom InstallHeaders class). It does seem that all other cases set 'headers': '$base/include/$dist_name' though (that might be a one line fix for the issue if it doesn't cause other issues).

Here are two lines from the build logs.

copying include/pybind11/eval.h -> /var/tmp/portage/dev-python/pybind11-2.4.3/image/_python3.6/usr/include/python3.6m/pybind11/

copying include/pybind11/eval.h -> /var/tmp/portage/dev-python/pybind11-2.4.3/image/_pypy3/usr/lib/pypy3.6/include/

Existing pull request: https://github.com/gentoo/gentoo/pull/14820
Related to: https://bugs.gentoo.org/465546

Reproducible: Always
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-06-30 16:05:32 UTC
Thank you for doing it.  I'll merge it now.
Comment 2 Larry the Git Cow gentoo-dev 2020-06-30 18:50:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=19ed19a661de36d2e2098d16477eb46c63c93639

commit 19ed19a661de36d2e2098d16477eb46c63c93639
Author:     Tom Gillespie <tgbugs@gmail.com>
AuthorDate: 2020-03-02 05:37:24 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-06-30 18:50:20 +0000

    dev-python/pypy3: fix headers install_dir
    
    Related to https://bugs.gentoo.org/465546
    
    Signed-off-by: Tom Gillespie <tgbugs@gmail.com>
    Closes: https://bugs.gentoo.org/729962
    Closes: https://github.com/gentoo/gentoo/pull/14820
    [rebased for 7.3.1]
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/pypy3/files/7.3.1-gentoo-path.patch                 | 2 +-
 dev-python/pypy3/{pypy3-7.3.1.ebuild => pypy3-7.3.1-r1.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)