Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 729418 - app-cdr/dvd+rw-tools fails to compile with Clang
Summary: app-cdr/dvd+rw-tools fails to compile with Clang
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: systemwide-clang
  Show dependency tree
 
Reported: 2020-06-24 11:20 UTC by Agostino Sarubbo
Modified: 2021-03-16 06:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,15.63 KB, text/plain)
2020-06-24 11:20 UTC, Agostino Sarubbo
Details
dvd+rw-tools-7.1-clang.patch (dvd+rw-tools-7.1-clang.patch,1.45 KB, patch)
2021-01-13 20:10 UTC, Markus Peloquin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-06-24 11:20:42 UTC
@@This is an auto-filed bug@@
Feel free to change the summary at your convenience.

Issue: app-cdr/dvd+rw-tools fails to compile.
Discovered on: amd64

NOTE:
If yout think this issue is related to clang/llvm toolchain, please block bug 408963. If you need further logs, feel free to ask.
Comment 1 Agostino Sarubbo gentoo-dev 2020-06-24 11:20:49 UTC
Created attachment 646026 [details]
build.log

build log and emerge --info
Comment 2 Markus Peloquin 2021-01-13 20:10:08 UTC
Created attachment 682765 [details, diff]
dvd+rw-tools-7.1-clang.patch

String literals in C++11 must not be directly proceeded by \w characters.

Compilation doesn't specify a version via -std=c++98. And maybe that would work. But this just fixes it so it can parse.
Comment 3 Agostino Sarubbo gentoo-dev 2021-01-14 07:30:42 UTC
Hello, thanks for the patch. I believe you can speed up the process by making a pull-request via Github.
Comment 4 Paolo Pedroni 2021-01-26 17:29:17 UTC
(In reply to Markus Peloquin from comment #2)
> Created attachment 682765 [details, diff] [details, diff]
> dvd+rw-tools-7.1-clang.patch
> 
> String literals in C++11 must not be directly proceeded by \w characters.
> 
> Compilation doesn't specify a version via -std=c++98. And maybe that would
> work. But this just fixes it so it can parse.

Thanks. This works!
Comment 5 Larry the Git Cow gentoo-dev 2021-03-16 06:54:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=116f8966c17e6ed5d5fe426a6ace8fb0ac416632

commit 116f8966c17e6ed5d5fe426a6ace8fb0ac416632
Author:     Viorel Munteanu <ceamac.paragon@gmail.com>
AuthorDate: 2021-03-15 17:16:26 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-03-16 06:50:28 +0000

    app-cdr/dvd+rw-tools: fix compilation with clang
    
    Closes: https://bugs.gentoo.org/729128
    Closes: https://bugs.gentoo.org/729418
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/19935
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 app-cdr/dvd+rw-tools/dvd+rw-tools-7.1-r4.ebuild    | 58 ++++++++++++++++++
 .../files/dvd+rw-tools-7.1-clang.patch             | 71 ++++++++++++++++++++++
 app-cdr/dvd+rw-tools/metadata.xml                  |  9 ++-
 3 files changed, 137 insertions(+), 1 deletion(-)