Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 729216 - [GURU] games-fps/crispy-doom: Buffer overflow vulnerability (CVE-2020-14983)
Summary: [GURU] games-fps/crispy-doom: Buffer overflow vulnerability (CVE-2020-14983)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: Normal trivial
Assignee: GURU project: Gentoo devs
URL: https://nvd.nist.gov/vuln/detail/CVE-...
Whiteboard: ~3 [noglsa]
Keywords: PullRequest
Depends on:
Blocks: CVE-2020-14983
  Show dependency tree
 
Reported: 2020-06-22 23:01 UTC by John Helmert III
Modified: 2020-08-20 17:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2020-06-22 23:01:02 UTC
From $URL:

"The server in Chocolate Doom 3.0.0 and Crispy Doom 5.8.0 doesn't validate the user-controlled num_players value, leading to a buffer overflow. A malicious user can overwrite the server's stack."

The member of the chocolate-doom Github organization that self-assigned the chocolate-doom Github issue is the maintainer of the crispy-doom repository, so I imagine the same response applies - will commit the fix when CVE is assigned.
Comment 1 William Breathitt Gray 2020-06-23 13:00:38 UTC
Upstream issue tracker: https://github.com/chocolate-doom/chocolate-doom/issues/1293
Comment 2 Aaron Bauman (RETIRED) gentoo-dev 2020-07-28 19:33:34 UTC
security team does not cover the GURU repo.
Comment 3 William Breathitt Gray 2020-08-19 12:40:21 UTC
Crispy Doom version 5.9.0 was released today and contains the CVE-2020-14983: https://github.com/fabiangreffrath/crispy-doom/releases/tag/crispy-doom-5.9.0

I have pushed a commit to the GURU dev branch removing the vulnerable crispy-doom packages and adding a new one for the fixed crispy-doom 5.9.0 version.
Comment 4 Larry the Git Cow gentoo-dev 2020-08-20 07:48:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=d15be3e5318904110322c031dd2325b004db82e4

commit d15be3e5318904110322c031dd2325b004db82e4
Author:     William Breathitt Gray <vilhelm.gray@gmail.com>
AuthorDate: 2020-08-19 12:34:56 +0000
Commit:     William Breathitt Gray <vilhelm.gray@gmail.com>
CommitDate: 2020-08-19 12:34:56 +0000

    games-fps/cripsy-doom: Version bump to 5.9.0
    
    Bug: https://bugs.gentoo.org/729216
    Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

 games-fps/crispy-doom/Manifest                     |  3 +-
 games-fps/crispy-doom/crispy-doom-5.7.2.ebuild     | 42 ----------------------
 ...-doom-5.8.0.ebuild => crispy-doom-5.9.0.ebuild} | 33 ++++++++++++++---
 games-fps/crispy-doom/metadata.xml                 |  1 +
 4 files changed, 31 insertions(+), 48 deletions(-)
Comment 5 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2020-08-20 17:07:36 UTC
Thanks. All done.