Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 729188 - net-libs/libvncserver-0.9.13: missing dependencies for turbojpeg test
Summary: net-libs/libvncserver-0.9.13: missing dependencies for turbojpeg test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexander Tsoy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-06-22 15:30 UTC by Rolf Eike Beer
Modified: 2022-09-24 10:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2020-06-22 15:30:14 UTC 
In the CMakeLists.txt it is wrapped behind this:

if(WITH_JPEG AND FOUND_LIBJPEG_TURBO)

So if things are installed the additional test is run, and otherwise it is not run.
Comment 1 Alexander Tsoy 2020-06-24 14:06:57 UTC 
So you are suggesting to add "test? ( media-libs/libjpeg-turbo )" to DEPEND? But users with media-libs/jpeg installed will not be able to run tests then.
Comment 2 Larry the Git Cow gentoo-dev 2020-06-27 12:15:51 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4917a4e4865c7854528acd1d95c7c1996aa57214

commit 4917a4e4865c7854528acd1d95c7c1996aa57214
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2020-06-25 11:15:54 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-06-27 12:15:37 +0000

    net-libs/libvncserver: Fix tests
    
    * Fix includetest with CMAKE_MAKEFILE_GENERATOR=ninja
    * Do not run tjunittest with USE=-jpeg
    
    Commiting straight to stable as only tests are affected by these
    changes.
    
    Closes: https://bugs.gentoo.org/729092
    Bug: https://bugs.gentoo.org/729188
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Closes: https://github.com/gentoo/gentoo/pull/16411
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../libvncserver-0.9.13-test-fix-includetest.patch | 54 ++++++++++++++++++++++
 .../libvncserver-0.9.13-test-fix-tjunittest.patch  | 29 ++++++++++++
 net-libs/libvncserver/libvncserver-0.9.13.ebuild   |  5 ++
 3 files changed, 88 insertions(+)