Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 728736 - sys-apps/dstat: csv output is broken
Summary: sys-apps/dstat: csv output is broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Paul Healy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-06-19 08:40 UTC by Tomáš Mózes
Modified: 2020-07-16 14:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Mózes 2020-06-19 08:40:13 UTC
# dstat --output /tmp/1.csv
You did not select any stats, using -cdngy by default.
Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.7/dstat", line 2830, in <module>
    main()
  File "/usr/lib/python-exec/python3.7/dstat", line 2689, in main
    scheduler.run()
  File "/usr/lib/python3.7/sched.py", line 151, in run
    action(*argument, **kwargs)
  File "/usr/lib/python-exec/python3.7/dstat", line 2789, in perform
    oline = oline + o.showcsv() + o.showcsvend(totlist, vislist)
  File "/usr/lib/python-exec/python3.7/dstat", line 549, in showcsv
    if isinstance(self.val[name], types.ListType) or isinstance(self.val[name], types.TupleType):
NameError: name 'types' is not defined
Comment 1 Paul Healy 2020-06-21 12:04:57 UTC
Proxy maintainer ACK - I recreated the issue and verified that the fix in the pull request works.
Comment 2 Larry the Git Cow gentoo-dev 2020-07-16 14:38:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dfe7211eaba93e58b530ec6fd80f3478e4ec3653

commit dfe7211eaba93e58b530ec6fd80f3478e4ec3653
Author:     Tomáš Mózes <hydrapolic@gmail.com>
AuthorDate: 2020-06-19 09:18:02 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-07-16 14:38:40 +0000

    sys-apps/dstat: fix csv output
    
    Closes: https://bugs.gentoo.org/728736
    Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16322
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 sys-apps/dstat/dstat-0.7.4-r2.ebuild      | 56 +++++++++++++++++++++++++++++++
 sys-apps/dstat/files/fix-csv-output.patch | 21 ++++++++++++
 2 files changed, 77 insertions(+)