Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 728560 - media-gfx/openscad-9999: patch failed with openscad-2019.05-0001-Fix-build-with-boost-1.73.patch
Summary: media-gfx/openscad-9999: patch failed with openscad-2019.05-0001-Fix-build-wi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernd
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-06-17 12:11 UTC by Michael Moon
Modified: 2020-07-20 09:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated openscad-9999.ebuild (openscad-9999.ebuild,1.86 KB, text/plain)
2020-07-02 13:06 UTC, Marian Kyral
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Moon 2020-06-17 12:11:12 UTC
>>> Preparing source in /var/tmp/portage/media-gfx/openscad-9999/work/openscad-9999 ...
* Applying openscad-2019.05-0001-Fix-build-with-boost-1.73.patch ...
patching file src/import.cc
Hunk #1 FAILED at 50.
1 out of 1 hunk FAILED -- saving rejects to file src/import.cc.rej                                                                                                                                                                                     [ !! ]
* ERROR: media-gfx/openscad-9999::gentoo failed (prepare phase):
*   patch -p1  failed with /var/tmp/portage/media-gfx/openscad-9999/files/openscad-2019.05-0001-Fix-build-with-boost-1.73.patch

I guess bug 722302 has been fixed upstream

I simply removed PATCHES=() from the ebuild and it seems to work fine.
Comment 1 Alexey Korepanov 2020-06-19 20:15:01 UTC
same here
Comment 2 Marian Kyral 2020-07-02 13:04:54 UTC
This patch is no more needed. I just build openscad without it.

# eix openscad
[I] media-gfx/openscad
     Available versions:  2019.05-r2 (~)2019.05-r3^t (**)9999*l^t {ccache emacs}
     Installed versions:  9999^t[1](15:02:10 2.7.2020)(-ccache -emacs)
     Homepage:            https://www.openscad.org/
     Description:         The Programmers Solid 3D CAD Modeller

[1] "mkyral" /usr/local/portage
Comment 3 Marian Kyral 2020-07-02 13:06:34 UTC
Created attachment 647354 [details]
updated openscad-9999.ebuild
Comment 4 Alexey Korepanov 2020-07-02 13:07:12 UTC
Yes, this is what Michael and myself wrote about.

We just need someone to remove this patch. It's very simple, but everyone is very busy.
Comment 5 Bernd 2020-07-02 17:31:39 UTC
I will have time this weekend and fix this issue. I'm sorry for the delay..., currently I'm busy with work.
Comment 6 Larry the Git Cow gentoo-dev 2020-07-20 09:01:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b2cdee2afeaf743367c789d3c3fa03ea41a2b300

commit b2cdee2afeaf743367c789d3c3fa03ea41a2b300
Author:     Bernd Waibel <waebbl@gmail.com>
AuthorDate: 2020-07-06 18:29:48 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-07-20 09:01:20 +0000

    media-gfx/openscad: remove unneeded patch
    
    Remove a backported patch which is no longer needed for live
    ebuild.
    
    Reported-by: Michael Moon <triffid.hunter@gmail.com>
    Closes: https://bugs.gentoo.org/728560
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Bernd Waibel <waebbl@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16616
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-gfx/openscad/openscad-9999.ebuild | 4 ----
 1 file changed, 4 deletions(-)