Created attachment 644616 [details, diff] patchage-1.0.2_string.patch Patchage doesn't compile due to a typo (missing namespace) in src/Patchage.cpp It also require ganv >=1.5.2, the ebuild states >=1.4.0 Attached patch fixes the first issue.
was this already reported upstream?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a357c9bbb53ff112340d84359b1cd062750603db commit a357c9bbb53ff112340d84359b1cd062750603db Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-06-15 09:40:57 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-06-15 09:40:57 +0000 media-sound/patchage: fixed compilation and dep in 1.0.2 Closes: https://bugs.gentoo.org/728178 Package-Manager: Portage-2.3.101, Repoman-2.3.22 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/patchage/files/patchage-1.0.2-string.patch | 11 +++++++++++ media-sound/patchage/patchage-1.0.2.ebuild | 6 +++++- 2 files changed, 16 insertions(+), 1 deletion(-)
Is there any particular reason why the patch is commented out in the ebuild? The patch isn't applied so patchage still doesn't compile. When I modify the ebuild so the patch is applied patchage compiles fine.
(In reply to Thomas Petersen from comment #3) > Is there any particular reason why the patch is commented out in the ebuild? > The patch isn't applied so patchage still doesn't compile. > > When I modify the ebuild so the patch is applied patchage compiles fine. the reason is probably the fact that when i tested the ebuild before commit, i found out that patchage (in my case) does not need the string patch and forgot to enable the patch again.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a3f4eba72a8ec012c076406b965feff106a27a97 commit a3f4eba72a8ec012c076406b965feff106a27a97 Author: Miroslav Šulc <fordfrog@gentoo.org> AuthorDate: 2020-08-29 12:16:11 +0000 Commit: Miroslav Šulc <fordfrog@gentoo.org> CommitDate: 2020-08-29 12:16:11 +0000 media-sound/patchage: enabled string patch Bug: https://bugs.gentoo.org/728178 Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org> media-sound/patchage/patchage-1.0.2.ebuild | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
