Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 728096 - games-roguelike/angband-4.2.x using SDL2 has no working sound
Summary: games-roguelike/angband-4.2.x using SDL2 has no working sound
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-12 19:17 UTC by likeslisp
Modified: 2020-08-10 22:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description likeslisp 2020-06-12 19:17:31 UTC
Angband doesn't have any sound in the SDL2 version. Upon launching the game and setting use_sound=yes in the UI settings in-game (accessed by pressing '=' and then 'a'), no sounds are ever played. When running `angband --help` in the console, no sound modules are listed under the sound module tab in the output. 

In version 4.2.0 the sdl2 USE flag could be disabled so that the sdl USE flag kicked in, which had working sound. This allowed running e.g. `angband -ssdl -mgcu` to get sound in the terminal version, or simply running the Angband SDL version with sound. It seems the sdl2 USE flag has been removed entirely in version 4.2.1, which now only offers SDL2 support in the ebuild from what I can tell (and hence no sound).

I believe sound should work in both versions if you compiled the sound from the regular SDL system regardless of the UI system being used.

The application is compiled with all USE="X ncurses sdl sound".
Comment 1 Stefan Strogin gentoo-dev 2020-06-16 08:32:57 UTC
Thanks for the report. If I'm not mistaken, it is an upstream bug. Would you report it there https://github.com/angband/angband/issues ?
Comment 2 likeslisp 2020-06-18 19:11:48 UTC
I'm not familiar with the development of Angband so I'm not really sure if it classifies as a bug or not. From what I can see the SDL2 frontend was recently introduced with v4.2.0 (Aug. 2019) as seen in the release history: https://rephial.org/release/4.2.0
However I'm not sure if that includes sound working in SDL2.

Nevertheless it would be nice to have a workaround in the Gentoo package allowing it to use the regular sdl version for sound only until sound is fixed/added upstream. As mentioned sound worked perfectly in 4.2.0 when using the sdl flag, even in the terminal version. It should probably be simple to install the SDL sound module for the package if the sound USE flag is enabled.

I will also experiment with compiling from source and report it as a bug upstream if the issue is the same there.
Comment 3 Larry the Git Cow gentoo-dev 2020-08-10 22:23:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6052cff30f398cf28089db8988666c6c2a189116

commit 6052cff30f398cf28089db8988666c6c2a189116
Author:     Stefan Strogin <steils@gentoo.org>
AuthorDate: 2020-08-10 22:14:48 +0000
Commit:     Stefan Strogin <steils@gentoo.org>
CommitDate: 2020-08-10 22:23:30 +0000

    games-roguelike/angband: add patch to fix SDL2 sound
    
    Closes: https://bugs.gentoo.org/728096
    Package-Manager: Portage-3.0.2, Repoman-2.3.23
    Signed-off-by: Stefan Strogin <steils@gentoo.org>

 games-roguelike/angband/angband-4.2.1-r1.ebuild    | 108 +++++++++++++++++++++
 .../angband/files/angband-4.2.1-sdl2-sound.patch   |  50 ++++++++++
 2 files changed, 158 insertions(+)