Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 727870 - net-misc/remmina-1.4.6 USE=examples - .../work/Remmina-v1.4.5/plugins/tool_hello_world/plugin.c:49:24: error: ‘RemminaPluginService’ {aka ‘struct _RemminaPluginService’} has no member named ‘_debug’
Summary: net-misc/remmina-1.4.6 USE=examples - .../work/Remmina-v1.4.5/plugins/tool_he...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ben Kohler
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-06-10 18:50 UTC by Jiří Moravec
Modified: 2020-06-18 13:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Extend changes made by upstream commits up to 9c1683a3 to plugins/tool_hello_world/* (remmina-1.4.5-Introduce-remmina_plugin_debug-for-plugins-to-plugins-tool_hello_world.patch,1.43 KB, patch)
2020-06-10 18:50 UTC, Jiří Moravec 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiří Moravec 2020-06-10 18:50:40 UTC 
Created attachment 644316 [details, diff]
Extend changes made by upstream commits up to 9c1683a3 to plugins/tool_hello_world/*

With USE=examples, compilation of both still unstable versions of remmina package (1.4.5, 1.4.6) failed with message:

/var/tmp/portage/net-misc/remmina-1.4.5/work/Remmina-v1.4.5/plugins/tool_hello_world/plugin.c:49:24: error: ‘RemminaPluginService’ {aka ‘struct _RemminaPluginService’} has no member named ‘_debug’
   49 |  remmina_plugin_service->_debug("[%s] Plugin init", PLUGIN_NAME);
      |                        ^~
...

This failure is caused by apparent upstream bug. Upstream commit 9c1683a3, probably by mistake, ignored plugins/tool_hello_world/plugin.c file. 

With USE=-examples plugins/tool_hello_world/ directory is ignored, so no error.
Comment 1 Opportunist 2020-06-17 17:05:31 UTC 
confirm on amd64
Comment 2 Ben Kohler gentoo-dev 2020-06-18 12:44:35 UTC 
This has been reported & fixed upstream but I'm not sure when their next release will be.  I'll add this patch to our build.
Comment 3 Larry the Git Cow gentoo-dev 2020-06-18 13:27:38 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0eae940a426b85831abb2deea89fdcbbcd55b4e4

commit 0eae940a426b85831abb2deea89fdcbbcd55b4e4
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2020-06-18 13:26:45 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2020-06-18 13:27:28 +0000

    net-misc/remmina: add patch for USE=examples
    
    Also drop (afaik) unneeded xdg_src_prepare as it caused double-applied
    patches & is not needed.
    
    Closes: https://bugs.gentoo.org/727870
    Package-Manager: Portage-2.3.101, Repoman-2.3.22
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 .../files/remmina-1.4.6-with-examples.patch        | 34 ++++++++++++++++++++++
 net-misc/remmina/remmina-1.4.6.ebuild              |  2 +-
 2 files changed, 35 insertions(+), 1 deletion(-)