Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 727866 - app-emulation/firecracker should install jailer
Summary: app-emulation/firecracker should install jailer
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2020-06-10 18:16 UTC by Sebastian Hamann
Modified: 2020-06-11 09:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
firecracker-0.21.1.ebuild (firecracker-0.21.1.ebuild,1.78 KB, text/plain)
2020-06-10 18:18 UTC, Sebastian Hamann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Hamann 2020-06-10 18:16:43 UTC
According to the official documentation at https://github.com/firecracker-microvm/firecracker/blob/master/docs/design.md firecracker should be started by the jailer program, which is part of the firecracker code repository:
> In production environments, Firecracker should be started only via the jailer binary. The firecracker binary can also be executed directly, but this will no longer be possible in the future.

The current Gentoo ebuilds for firecracker (all versions) compiles jailer but does not install the binary.
The obvious fix to install the jailer binary along with the firecracker binary. I'll attach a modified ebuild (based on version 0.21.1).

Reproducible: Always

Steps to Reproduce:
1. emerge firecracker
2. jailer
Actual Results:  
command not found: jailer

Expected Results:  
jailer fails due to missing command line parameters
Comment 1 Sebastian Hamann 2020-06-10 18:18:29 UTC
Created attachment 644312 [details]
firecracker-0.21.1.ebuild

Modified version of current firecracker ebuild that installs the jailer binary
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-10 20:01:00 UTC
Comment on attachment 644312 [details]
firecracker-0.21.1.ebuild

--- a/firecracker-0.21.1.ebuild
+++ b/firecracker-0.21.1.ebuild
@@ -83,4 +83,5 @@
        local target_arch
        set_target_arch
        dobin "${S}"/build/cargo_target/${target_arch}-unknown-linux-gnu/release/${PN}
+       dobin "${S}"/build/cargo_target/${target_arch}-unknown-linux-gnu/release/jailer
 }
Comment 3 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2020-06-10 20:41:32 UTC
I think you may submit a pull request if you want your name on the commit changes :)
Comment 4 Sebastian Hamann 2020-06-11 05:45:33 UTC
(In reply to Mikle Kolyada from comment #3)
> I think you may submit a pull request if you want your name on the commit
> changes :)

I don't care much about names, but if that helps getting this into the tree faster, I'm happy to help :)

I rev-bumped the latest version as that seemed appropriate to me. If you prefer anything else, just let me know.
Comment 5 Larry the Git Cow gentoo-dev 2020-06-11 09:05:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d07d0ac7496e06fc8657b7d17d4c231e8343bf1f

commit d07d0ac7496e06fc8657b7d17d4c231e8343bf1f
Author:     Sebastian Hamann <code@ares-macrotechnology.com>
AuthorDate: 2020-06-11 05:34:38 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2020-06-11 09:05:28 +0000

    app-emulation/firecracker: install jailer binary
    
    Install the jailer binary along with firecracker
    
    Signed-off-by: Sebastian Hamann <code@ares-macrotechnology.com>
    Closes: https://bugs.gentoo.org/727866
    Closes: https://github.com/gentoo/gentoo/pull/16186
    Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>

 .../firecracker/firecracker-0.21.1-r1.ebuild       | 87 ++++++++++++++++++++++
 1 file changed, 87 insertions(+)