Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 727650 - sys-apps/bolt-0.8-r1 - !!! Fetched file: bolt-210.patch VERIFY FAILED!
Summary: sys-apps/bolt-0.8-r1 - !!! Fetched file: bolt-210.patch VERIFY FAILED!
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-09 12:08 UTC by Jeroen Roovers (RETIRED)
Modified: 2020-06-10 06:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2020-06-09 12:08:13 UTC
>>> Downloading 'https://gitlab.freedesktop.org/bolt/bolt/merge_requests/210.patch'
--2020-06-09 13:56:45--  https://gitlab.freedesktop.org/bolt/bolt/merge_requests/210.patch
Resolving gitlab.freedesktop.org (gitlab.freedesktop.org)... 35.227.58.183
Connecting to gitlab.freedesktop.org (gitlab.freedesktop.org)|35.227.58.183|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://gitlab.freedesktop.org/bolt/bolt/-/merge_requests/210.patch [following]
--2020-06-09 13:56:46--  https://gitlab.freedesktop.org/bolt/bolt/-/merge_requests/210.patch
Reusing existing connection to gitlab.freedesktop.org:443.
HTTP request sent, awaiting response... 200 OK
Length: 696 [text/plain]
Saving to: ‘/aches/gentoo/distfiles/bolt-210.patch.__download__’

/aches/gentoo/distfiles/bolt-210.patch. 100%[===================>]     696  --.-KB/s    in 0s

2020-06-09 13:56:46 (68.5 MB/s) - ‘/aches/gentoo/distfiles/bolt-210.patch.__download__’ saved [696/696]

!!! Fetched file: bolt-210.patch VERIFY FAILED!
!!! Reason: Filesize does not match recorded size
!!! Got:      696
!!! Expected: 694
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-09 12:10:19 UTC
diff -u bolt-210.patch 210.patch
--- bolt-210.patch      2020-01-30 23:54:01.000000000 +0100
+++ 210.patch   2020-06-09 14:09:12.055101253 +0200
@@ -10,7 +10,7 @@
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/common/bolt-error.h b/common/bolt-error.h
-index 569da46..0486964 100644
+index 569da46f..04869643 100644
 --- a/common/bolt-error.h
 +++ b/common/bolt-error.h
 @@ -36,7 +36,7 @@ G_BEGIN_DECLS
@@ -23,5 +23,5 @@
    BOLT_ERROR_UDEV,
    BOLT_ERROR_NOKEY,
 --
-2.24.1
+2.26.2
Comment 2 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2020-06-09 21:07:00 UTC
localy, I just regenerated (refetched as well) the checksums remained the same with the filesize at 694
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-09 21:16:40 UTC
(In reply to Matthew Thode ( prometheanfire ) from comment #2)
> localy, I just regenerated (refetched as well) the checksums remained the
> same with the filesize at 694

Then you obviously didn't fetch the second copy from gitlab.freedesktop.org but from a Gentoo mirror. Or you did neither and just checked your local copy. Who knows? I provided (f)actual evidence. How about you?
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-09 21:24:45 UTC
23:20:51 @<prometheanfire> rej: no need to be mean about it

I wasn't "mean". I am frankly annoyed. And I challenged you to provide factual evidence.
Comment 5 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2020-06-09 21:25:41 UTC
ya it was a mirror, forgot about that, now stop being a jerk.
Comment 6 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2020-06-09 21:26:39 UTC
it looks like gitlab updated it's version of git, which changed the generated patches, so that sucks
Comment 7 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-09 21:26:55 UTC
curl -L https://gitlab.freedesktop.org/bolt/bolt/-/merge_requests/210.patch | diff -u "${DISTDIR}"/bolt-210.patch -
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   696  100   696    0     0   1693      0 --:--:-- --:--:-- --:--:--  1689
--- /aches/gentoo/distfiles/bolt-210.patch      2020-01-30 23:54:01.000000000 +0100
+++ -   2020-06-09 23:15:03.932410454 +0200
@@ -10,7 +10,7 @@
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/common/bolt-error.h b/common/bolt-error.h
-index 569da46..0486964 100644
+index 569da46f..04869643 100644
 --- a/common/bolt-error.h
 +++ b/common/bolt-error.h
 @@ -36,7 +36,7 @@ G_BEGIN_DECLS
@@ -23,5 +23,5 @@
    BOLT_ERROR_UDEV,
    BOLT_ERROR_NOKEY,
 --
-2.24.1
+2.26.2



Reproduce this or close this bug report as INVALID.
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-09 21:27:32 UTC
(In reply to Matthew Thode ( prometheanfire ) from comment #6)
> it looks like gitlab updated it's version of git, which changed the
> generated patches, so that sucks

Right, updating git sucks. I showed you that in comment #1.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-09 21:28:02 UTC
(In reply to Matthew Thode ( prometheanfire ) from comment #5)
> ya it was a mirror, forgot about that, now stop being a jerk.

Stop assigning emotions to the text I write. Thanks.
Comment 10 Larry the Git Cow gentoo-dev 2020-06-09 21:31:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=581992d518bbcd54a065dac61830f38041b7f8c1

commit 581992d518bbcd54a065dac61830f38041b7f8c1
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: 2020-06-09 21:31:17 +0000
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: 2020-06-09 21:31:44 +0000

    sys-apps/bolt: fix patch checksum error
    
    fixed in place as both a build error and a non-on disk install impacting
    change.
    
    error caused by gitlab updating the version of git and changing the
    dynamically generated patch.  Switched to a more static patch.
    
    Closes: https://bugs.gentoo.org/727650
    
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>

 sys-apps/bolt/Manifest           | 2 +-
 sys-apps/bolt/bolt-0.8-r1.ebuild | 4 ++--
 sys-apps/bolt/metadata.xml       | 3 ---
 3 files changed, 3 insertions(+), 6 deletions(-)
Comment 11 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2020-06-09 21:33:36 UTC
How we interface with eachother maters.  Working remote with eachother means we need to care about what we write and how we write it.
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2020-06-10 06:14:50 UTC
(In reply to Matthew Thode ( prometheanfire ) from comment #11)
> How we interface with eachother maters.  Working remote with eachother means
> we need to care about what we write and how we write it.

I completely agree:

1) Don't call people "mean" or "jerks" when they point out problems or disagree with you.
2) Do not dismiss the problems people report without proper investigation.
3) Assume the reporter did more work in good faith to file the report than you can superficially (or initially) tell.


Thanks for fixing this.