Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 727540 - app-emulation/winetricks USE=test should depend on || ( dev-util/shellcheck-bin dev-util/shellcheck )
Summary: app-emulation/winetricks USE=test should depend on || ( dev-util/shellcheck-b...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chiitoo
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-06-08 15:19 UTC by Jannik Glückert
Modified: 2020-07-14 00:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jannik Glückert 2020-06-08 15:19:27 UTC
winetricks pulls in dev-util/shellcheck as a test dep without having the option for dev-util/shellcheck-bin

I'd prefer to see
test? ( || ( dev-util/shellcheck-bin dev-util/shellcheck ) )
so we can keep dependencies slim if possible
Comment 1 Larry the Git Cow gentoo-dev 2020-06-30 14:02:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/proj/wine.git/commit/?id=ce4366c9671d979fc3322e7d83cccd4a81b1ad2a

commit ce4366c9671d979fc3322e7d83cccd4a81b1ad2a
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: 2020-06-25 17:27:25 +0000
Commit:     Jimi Huotari <chiitoo@gentoo.org>
CommitDate: 2020-06-25 17:28:20 +0000

    app-emulation/winetricks: add 'dev-util/shellcheck-bin' as an option
    
    Reported-by: Jannik Glückert <jannik.glueckert@gmail.com>
    Bug: https://bugs.gentoo.org/727540
    Package-Manager: Portage-2.3.102, Repoman-2.3.23
    Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>

 app-emulation/winetricks/winetricks-20200412.ebuild | 5 ++++-
 app-emulation/winetricks/winetricks-99999999.ebuild | 7 +++++--
 2 files changed, 9 insertions(+), 3 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2020-07-14 00:34:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74ce167e9ee6c71fc5578d8271083627933c325c

commit 74ce167e9ee6c71fc5578d8271083627933c325c
Author:     Nick Sarnie <sarnex@gentoo.org>
AuthorDate: 2020-07-14 00:33:32 +0000
Commit:     Nick Sarnie <sarnex@gentoo.org>
CommitDate: 2020-07-14 00:34:03 +0000

    app-emulation/winetricks: Sync with ::wine
    
    Closes: https://bugs.gentoo.org/727540
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Nick Sarnie <sarnex@gentoo.org>

 app-emulation/winetricks/winetricks-20200412.ebuild | 5 ++++-
 app-emulation/winetricks/winetricks-99999999.ebuild | 7 +++++--
 2 files changed, 9 insertions(+), 3 deletions(-)