Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 727110 - www-client/firefox-77.0.1 fails to merge due to UnicodeEncodeError in python/mozbuild/mozbuild/controller/building.py
Summary: www-client/firefox-77.0.1 fails to merge due to UnicodeEncodeError in python/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 728630 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-06-04 11:50 UTC by Bas Weelinck
Modified: 2020-10-04 14:05 UTC (History)
19 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Firefox build logs of both Clang and GCC builds. (firefox-build-logs.tgz,185.24 KB, application/x-gtar)
2020-06-04 11:54 UTC, Bas Weelinck
Details
emerge --info output. (emerge_info.txt,5.99 KB, text/plain)
2020-06-04 11:56 UTC, Bas Weelinck
Details
My build.log (build.log.tar.xz,61.58 KB, application/x-xz)
2020-06-10 04:37 UTC, Mamadou Babaei
Details
My emerge --info (emerge-info.txt,5.73 KB, text/plain)
2020-06-10 04:37 UTC, Mamadou Babaei
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bas Weelinck 2020-06-04 11:50:02 UTC
The summary pretty much sums it up, Firefox fails to merge. I've tested this both with Clang and GCC (since this was the first time I merged a Firefox ebuild with Clang, I wanted to rule out a difference there)

This bug is in essence the same report as described by bug 646062 .

I'm upgrading from 76.0.1

I will also be re-merging firefox 76.0.1 to verify this still builds successfully.
Comment 1 Bas Weelinck 2020-06-04 11:54:50 UTC
Created attachment 643398 [details]
Firefox build logs of both Clang and GCC builds.

The files were to large individually to be submitted as text, so I compressed both into an archive.
Comment 2 Bas Weelinck 2020-06-04 11:56:22 UTC
Created attachment 643400 [details]
emerge --info output.
Comment 3 Bas Weelinck 2020-06-04 12:13:17 UTC
I can now confirm Firefox 76.0.1 still builds fine, on the same system with no other packages changed.

So it's definitely something related to this build in particular.
Comment 4 tt_1 2020-06-04 12:22:37 UTC
The firefox-76.0 patchset used to carry a patch for patching the file in question, and I believe that patch was only needed when using distcc. You might want to try to disable distcc if you're actually using it.
Comment 5 Bas Weelinck 2020-06-04 12:24:49 UTC
Thanks for the info, I saw something along the same lines in the other bug report..

I am not using distcc however.
Comment 6 Jinseop Kim 2020-06-04 13:44:30 UTC
I have the same problem.
Comment 7 tonich 2020-06-04 14:43:13 UTC
Switching to python3.7 as default interpreter solved problem for me
Comment 8 Jinseop Kim 2020-06-04 16:09:49 UTC
I confirmed the build is success when using Python 3.8.
(I switched python version using package.env with PYTHON_COMPAT_OVERRIDE.)

I think need to change PYTHON_COMPAT.
Comment 9 Jinseop Kim 2020-06-04 16:11:01 UTC
(In reply to tonich from comment #7)
> Switching to python3.7 as default interpreter solved problem for me

@tonich, Thank you for sharing solution :-)
Comment 10 Thomas Deutschmann (RETIRED) gentoo-dev 2020-06-04 17:47:45 UTC
The patch (https://github.com/Whissi/gentoo-mozilla/commit/6c032b80c02e516a2d384f4aadf078d8b2e4aa7b) was dropped because it's now incompatible with upstream recent changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1623701
Comment 11 Bas Weelinck 2020-06-04 18:52:22 UTC
Alright, after switching to Python 3.7, Firefox 77.0.1 now also builds on my system.
Comment 12 Thibaud CANALE 2020-06-07 11:30:40 UTC
Hello,

About this issue, do you think there is a fix or a soon-to-be-released about building Firefox with Python 3.6, or can we consider the minimum required Python version is 3.7?
In case of the last choice, I think the ebuild should be updated. I would have preferred to stay a while longer on Python 3.6 or jumping over Python 3.7.

Best regards,
Comment 13 Mamadou Babaei 2020-06-10 04:37:10 UTC
Created attachment 644202 [details]
My build.log

I have the exact same issue. Here is my build.log
Comment 14 Mamadou Babaei 2020-06-10 04:37:40 UTC
Created attachment 644204 [details]
My emerge --info

And here is the emerge --info output
Comment 15 Mamadou Babaei 2020-06-10 04:39:21 UTC
I am not using distcc either. I only use ccache for building.
Comment 16 Mamadou Babaei 2020-06-10 04:39:45 UTC
I think it might be related to #641676
Comment 17 Mamadou Babaei 2020-06-10 04:40:20 UTC
(In reply to Mamadou Babaei from comment #16)
> I think it might be related to #641676

https://bugs.gentoo.org/641676
Comment 18 Philippe Valembois 2020-06-13 15:55:32 UTC
For those who don't want to switch to Python 3.7, emerging with PYTHONIOENCODING=utf8 environment varialbe makes it work.
Comment 19 Adrien Dessemond 2020-06-13 17:21:29 UTC
Good catch, setting PYTHONIOENCODING=utf8 solves the issue for me as well (Python 3.6.10 here).
Comment 20 Larry the Git Cow gentoo-dev 2020-06-17 14:22:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=25acf8cb8a1f42a7d9216a71cd5a63ee0f6bcd05

commit 25acf8cb8a1f42a7d9216a71cd5a63ee0f6bcd05
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-06-17 14:20:42 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-06-17 14:22:46 +0000

    www-client/firefox: require >Py3.6
    
    Closes: https://bugs.gentoo.org/727110
    Package-Manager: Portage-2.3.101, Repoman-2.3.22
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-77.0.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 21 Mart Raudsepp gentoo-dev 2020-06-18 09:51:58 UTC
*** Bug 728630 has been marked as a duplicate of this bug. ***
Comment 22 Gerhard Hintermayer 2020-06-18 10:31:32 UTC
recently filed a duplicate, since this is not shown under related bugs @ packages.gentoo.org - what am I missing ? BTW the fix is not yet in portage tree, right ? So manually emerging python3.7 and eselecting it is the temporary solution ? I can emerge FF without bailing out at the beginning due to wrong python version and fail after several minutes of compile time
Comment 23 Thomas Deutschmann (RETIRED) gentoo-dev 2020-06-18 11:50:36 UTC
Commit is in repository. Check the commit/date your repository is based on.
Comment 24 Ionen Wolkens gentoo-dev 2020-10-04 10:41:18 UTC
I believe already been told but this bug made a come back since the 0/esr78 and 0/81.0 ebuilds have python3_6 support again.
Comment 25 Larry the Git Cow gentoo-dev 2020-10-04 14:05:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=75daf88e505ff97d7cb50006e8688e59146a1fcd

commit 75daf88e505ff97d7cb50006e8688e59146a1fcd
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-04 14:05:06 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-10-04 14:05:19 +0000

    mail-client/thunderbird: require >Py3.6, again
    
    Bug: https://bugs.gentoo.org/727110
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 mail-client/thunderbird/thunderbird-78.3.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=804b4ae8e8bb7817658b7dc9b6892376fb74bfa2

commit 804b4ae8e8bb7817658b7dc9b6892376fb74bfa2
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-04 14:04:06 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-10-04 14:05:18 +0000

    www-client/firefox: require >Py3.6, again
    
    Bug: https://bugs.gentoo.org/727110
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-78.3.1.ebuild | 2 +-
 www-client/firefox/firefox-81.0.1.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)