Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 727002 - dev-libs/spdlog: please add shared lib build option
Summary: dev-libs/spdlog: please add shared lib build option
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: David Roman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-03 19:00 UTC by Eugene Shalygin
Modified: 2020-06-03 23:45 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Shalygin 2020-06-03 19:00:36 UTC
The spdlog ebuilds now pass `-DSPDLOG_BUILD_SHARED=no` unconditionally. Could you wrap that under "static" use flag, please? The problem is the static library is built without PIC enabled.

Reproducible: Always
Comment 1 David Seifert gentoo-dev 2020-06-03 20:04:58 UTC
why is this the case any way? I see no reason to build a static library, and without a very good explanation, I will switch it to build only a shared library.
Comment 2 David Roman 2020-06-03 20:23:36 UTC
(In reply to David Seifert from comment #1)
> why is this the case any way? I see no reason to build a static library, and
> without a very good explanation, I will switch it to build only a shared
> library.

The PR for the version update build the shared library
Comment 3 Eugene Shalygin 2020-06-03 21:21:26 UTC
The PR leaves the 9999 version unchanged, which would create a confusing situation.
Comment 4 Larry the Git Cow gentoo-dev 2020-06-03 21:43:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fea9b8917fdfdc79ecba1b652dfde7c9ba9ba682

commit fea9b8917fdfdc79ecba1b652dfde7c9ba9ba682
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-06-03 21:43:31 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-06-03 21:43:31 +0000

    dev-libs/spdlog: [QA] Build only shared libraries
    
    Closes: https://bugs.gentoo.org/727002
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-libs/spdlog/{spdlog-1.5.0.ebuild => spdlog-1.5.0-r1.ebuild} | 2 +-
 dev-libs/spdlog/spdlog-9999.ebuild                              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4767552c31fe77baca493afdbe0701d44b6fa78e

commit 4767552c31fe77baca493afdbe0701d44b6fa78e
Author:     David Roman <davidroman96@gmail.com>
AuthorDate: 2020-06-03 21:43:28 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-06-03 21:43:28 +0000

    dev-libs/spdlog: verbump to 1.6.0
    
    Closes: https://github.com/gentoo/gentoo/pull/15855
    Closes: https://bugs.gentoo.org/727002
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: David Roman <davidroman96@gmail.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

 dev-libs/spdlog/Manifest            |  1 +
 dev-libs/spdlog/spdlog-1.6.0.ebuild | 47 +++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=946386d214b0a32982660ee0b84705deefef2832

commit 946386d214b0a32982660ee0b84705deefef2832
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-06-03 21:43:37 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-06-03 21:43:37 +0000

    net-misc/gerbera: Slot dep operator on spdlog
    
    Bug: https://bugs.gentoo.org/727002
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: David Seifert <soap@gentoo.org>

 net-misc/gerbera/{gerbera-1.5.0.ebuild => gerbera-1.5.0-r1.ebuild} | 2 +-
 net-misc/gerbera/gerbera-9999.ebuild                               | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15e04b329427fa67268bb7ea910b799298093daa

commit 15e04b329427fa67268bb7ea910b799298093daa
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2020-06-03 21:43:34 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-06-03 21:43:34 +0000

    media-tv/kodi: Slot dep operator on spdlog
    
    Bug: https://bugs.gentoo.org/727002
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: David Seifert <soap@gentoo.org>

 media-tv/kodi/kodi-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 David Roman 2020-06-03 23:45:00 UTC
(In reply to Eugene Shalygin from comment #3)
> The PR leaves the 9999 version unchanged, which would create a confusing
> situation.

I just saw that the version 1.6.1 is available. I will send another PR which will also fix the live ebuild.