Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 726952 - net-analyzer/munin-2.0.56 - munin-node fails to start on boot - start-stop-daemon: did not create a valid pid in `/run/munin-node.pid'
Summary: net-analyzer/munin-2.0.56 - munin-node fails to start on boot - start-stop-da...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Sysadmin Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-03 15:45 UTC by Account Removed
Modified: 2023-07-23 05:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Account Removed 2020-06-03 15:45:32 UTC
System completely up-to-date as of 2020-06-02

ebuild net-analyzer/munin-2.0.56

munin-node fails to start on boot:

/var/log/messages:

Jun  3 17:29:57 <hostname> /etc/init.d/munin-node[3530]: start-stop-daemon: did not create a valid pid in `/run/munin-node.pid'
Jun  3 17:29:57 <hostname> /etc/init.d/munin-node[3509]: ERROR: munin-node failed to start

No process "*munin*" there after boot.

Have to start munin-node after boot manually with

/etc/init.d/munin-node start

only after that munin-node is in status running:

/etc/init.d/munin-node status
 * status: started
Comment 1 Account Removed 2020-06-03 15:46:41 UTC
Init-System is OpenRC
Comment 2 Account Removed 2020-06-03 15:49:41 UTC
After manually starting, things look ok:

cat /run/munin-node.pid
7004

pgrep munin-node
7004

So there is a problem with the pid file only on boot.
Comment 3 Account Removed 2020-06-14 14:57:47 UTC
The following modification of /etc/init.d/munin-node fixes the bug for me:

diff backup/munin-node ./munin-node 
20c20
<       before cron
---
>       need net

Without this patch, munin-node was tried to start right after syslog-ng as the second daemon according to /var/log/messages (when the network links where not up yet), which was apparently too early for some reason.
Comment 4 Account Removed 2020-06-14 15:17:20 UTC
BTW what is the reason for the "before cron" dependency? A comment should explain it.

I am not quite sure, if there is a use case when munin-node should run on a node without network (or at least without an init script resource that provides "net").
Maybe, also "net" is not really needed by munin-node, but something other, I don't know, it just fixes the bug for me, to depend on net.
Comment 5 Larry the Git Cow gentoo-dev 2023-07-23 05:56:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f9821904b8f12c035cfc02a1cce689b81228300

commit 1f9821904b8f12c035cfc02a1cce689b81228300
Author:     Hans de Graaff <graaff@gentoo.org>
AuthorDate: 2023-07-22 08:11:33 +0000
Commit:     Hans de Graaff <graaff@gentoo.org>
CommitDate: 2023-07-23 05:51:01 +0000

    net-analyzer/munin: depend on hostname and net in init file
    
    Closes: https://bugs.gentoo.org/726952
    Signed-off-by: Hans de Graaff <graaff@gentoo.org>

 net-analyzer/munin/files/munin-node_init.d_2.0.73 |  27 ++
 net-analyzer/munin/munin-2.0.73-r3.ebuild         | 417 ++++++++++++++++++++++
 2 files changed, 444 insertions(+)