Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 726446 - app-office/libreoffice-6.4.4.2 superflous USE flag logic?
Summary: app-office/libreoffice-6.4.4.2 superflous USE flag logic?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-05-31 13:23 UTC by Another Mortal
Modified: 2023-04-26 03:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Another Mortal 2020-05-31 13:23:05 UTC
Compared to 6.4.3.2, version 6.4.4.2 adds a USE flag
forcing `dbus` whenever `gtk` is selected.  Why?

I've been building libreoffice with `USE=+gtk -dbus`
for as long as I remember and never had a problem.

I also tested building 6.4.4.2 in an overly removing
the offending line "gtk? ( dbus )" from the build.
The build completed fine and libreoffice appears to
work as usual.

What is supposed to break without this USE change?
Comment 1 Andreas Sturmlechner gentoo-dev 2020-05-31 13:52:14 UTC
Missing menubar on 'minimalist WMs'. If there is a better solution I would be glad to use that, but there are too many people with 'minimalist WMs' and whatever missing config to tell everyone separately to use that workaround.
Comment 2 Another Mortal 2020-05-31 17:58:03 UTC
Many thanks for the super quick answer!!

I checked out the bug report you linked.

The root cause appears to be a missing +X USE flag on sys-apps/dbus.

I'm also using a 'minimalist WM' (fluxbox, no "desktop environment"),
BUT I do have sys-apps/dbus[X], and _still_ build libreoffice with
USE=-dbus...  whatever that means...

My first guess was that the libreoffice build system
may just _enable_ dbus support *despite* --disable-dbus,
if it detects that dbus is installed, but that does NOT
appear to be the case.

-------
# ebuild /etc/portage/overlay/app-office/libreoffice/libreoffice-6.4.4.2.ebuild configure
[...]
./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --disable-dependency-tracking --docdir=/usr/share/doc/libreoffice-6.4.4.2 --htmldir=/usr/share/doc/libreoffice-6.4.4.2/html --libdir=/usr/lib64 --with-system-dicts --with-system-epoxy --with-system-headers --with-system-jars --with-system-libs --enable-build-opensymbol --enable-cairo-canvas --enable-largefile --enable-mergelibs --enable-neon --enable-python=system --enable-randr --enable-release-build --disable-breakpad --disable-bundle-mariadb --disable-ccache --disable-epm --disable-fetch-external --disable-gtk3-kde5 --disable-online-update --disable-openssl --disable-pdfium --disable-report-builder --disable-vlc --with-build-version=Gentoo official package --enable-extension-integration --with-external-dict-dir=/usr/share/myspell --with-external-hyph-dir=/usr/share/myspell --with-external-thes-dir=/usr/share/myspell --with-external-tar=/var/tmp/portage/app-office/libreoffice-6.4.4.2/distdir --with-lang= --with-parallelism=4 --with-system-ucpp --with-tls=nss --with-vendor=Gentoo Foundation --with-x --without-fonts --without-myspell-dicts --with-help=html --without-helppack-integration --with-system-gpgmepp --without-system-sane --without-system-qrcodegen --disable-sdremote-bluetooth --disable-coinmp --enable-cups --disable-dbus --disable-debug --disable-evolution2 --disable-firebird-sdbc --disable-gstreamer-1-0 --enable-gtk3 --disable-kf5 --disable-qt5 --disable-ldap --disable-odk --disable-pdfimport --disable-postgresql-sdbc --without-lxml --without-system-coinmp --without-gdrive-client-id --without-gdrive-client-secret --without-java --without-doxygen --enable-dconf --enable-gio --disable-ext-nlpsolver --disable-scripting-beanshell --disable-scripting-javascript --disable-ext-wiki-publisher
[...]
checking for gtk+-3.0 >= 3.18 gtk+-unix-print-3.0 gmodule-no-export-2.0 glib-2.0 >= 2.38 cairo... yes
configure: VCLplugs to be built: gtk3
checking whether to enable DBUS support... no
[...]
-------

What that tells me is that it's gtk that needs dbus support NOT libreoffice.

If that's, in fact, correct, then the "right" USE change should be:

gtk? ( sys-apps/dbus[X] )

To be honest, I have no idea what libreoffice[dbus] entails;
so, take the above with the proverbial grain of natrium chloride.
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2020-12-10 18:46:15 UTC
libreoffice-7.0.3.1.ebuild:     gtk? ( dbus )
libreoffice-7.0.3.1.ebuild:     dbus? ( sys-apps/dbus[X] )

so not really anything to fix here.
Comment 4 Another Mortal 2020-12-10 23:11:37 UTC
OK. Whatever.. I'll just keep applying this change myself then:
==========
$ diff -u /usr/portage/app-office/libreoffice/libreoffice-7.0.3.1.ebuild /etc/portage/overlay/app-office/libreoffice/libreoffice-7.0.3.1.ebuild
--- /usr/portage/app-office/libreoffice/libreoffice-7.0.3.1.ebuild      2020-11-28 23:09:16.000000000 +0100
+++ /etc/portage/overlay/app-office/libreoffice/libreoffice-7.0.3.1.ebuild      2020-11-27 20:51:35.478135177 +0100
@@ -89,7 +89,6 @@
 REQUIRED_USE="${PYTHON_REQUIRED_USE}
        base? ( firebird java )
        bluetooth? ( dbus )
-       gtk? ( dbus )
        libreoffice_extensions_nlpsolver? ( java )
        libreoffice_extensions_scripting-beanshell? ( java )
        libreoffice_extensions_scripting-javascript? ( java )
==========
Comment 5 orbea 2023-04-08 00:18:26 UTC
Going to reopen this issue since the original issue with missing menubars in FVWM is no longer a problem according to the most recent comment in the original issue.

https://bugs.gentoo.org/716712#c18

(I hope I am not overstepping my bounds?)
Comment 6 Larry the Git Cow gentoo-dev 2023-04-14 00:51:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a1da65ccf1379f646dacf91f100d4c71a66f8843

commit a1da65ccf1379f646dacf91f100d4c71a66f8843
Author:     orbea <orbea@riseup.net>
AuthorDate: 2023-03-28 14:54:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-14 00:50:37 +0000

    app-office/libreoffice: Remove erroneous dbus dependency
    
    It is not required to build libreoffice with dbus support when gtk
    support is enabled.
    
    The original reporter confirms this.
    
    Closes: https://bugs.gentoo.org/726446
    Signed-off-by: orbea <orbea@riseup.net>
    Closes: https://github.com/gentoo/gentoo/pull/30393
    Signed-off-by: Sam James <sam@gentoo.org>

 app-office/libreoffice/libreoffice-7.3.7.2.ebuild  | 1 -
 app-office/libreoffice/libreoffice-7.4.4.2.ebuild  | 1 -
 app-office/libreoffice/libreoffice-7.4.6.2.ebuild  | 1 -
 app-office/libreoffice/libreoffice-7.4.9999.ebuild | 1 -
 app-office/libreoffice/libreoffice-7.5.2.2.ebuild  | 1 -
 app-office/libreoffice/libreoffice-7.5.9999.ebuild | 1 -
 app-office/libreoffice/libreoffice-9999.ebuild     | 1 -
 7 files changed, 7 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2023-04-26 03:51:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6c3df04b26e98cbd9ebb5baacd9c7bd668c4fcc

commit d6c3df04b26e98cbd9ebb5baacd9c7bd668c4fcc
Author:     orbea <orbea@riseup.net>
AuthorDate: 2023-04-16 17:02:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-04-26 03:47:04 +0000

    app-office/libreoffice: Don't require X for dbus
    
    It doesn't seem to be required anymore with LibreOffice.
    
    Bug: https://bugs.gentoo.org/726446
    Signed-off-by: orbea <orbea@riseup.net>
    Closes: https://github.com/gentoo/gentoo/pull/30620
    Signed-off-by: Sam James <sam@gentoo.org>

 app-office/libreoffice/libreoffice-7.4.9999.ebuild | 2 +-
 app-office/libreoffice/libreoffice-7.5.9999.ebuild | 2 +-
 app-office/libreoffice/libreoffice-9999.ebuild     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)