Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 725396 - sys-auth/sssd-2.3.0: version bump
Summary: sys-auth/sssd-2.3.0: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexey Shvetsov
URL: https://github.com/SSSD/sssd/releases...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-25 19:38 UTC by cmvu
Modified: 2020-08-14 09:12 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for sssd-2.3.0 (sssd-2.3.0.ebuild,5.88 KB, text/plain)
2020-05-25 19:41 UTC, cmvu
Details
sssd-2.3.0.ebuild (sssd-2.3.0[1].ebuild,5.93 KB, text/plain)
2020-06-08 22:46 UTC, Chris Pritchard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cmvu 2020-05-25 19:38:24 UTC
Version bump to latest available release. Note that SSSD project have migrated from pagure.io to github (Announcement here https://pagure.io/SSSD/sssd) and also deprecated support for nss as crypto provider more in release notes https://github.com/SSSD/sssd/releases/tag/sssd-2_3_0.



Reproducible: Always
Comment 1 cmvu 2020-05-25 19:41:09 UTC
Created attachment 641782 [details]
ebuild for sssd-2.3.0
Comment 2 Joakim Tjernlund 2020-06-01 11:40:49 UTC
(In reply to cmvu from comment #0)
> Version bump to latest available release. Note that SSSD project have
> migrated from pagure.io to github (Announcement here
> https://pagure.io/SSSD/sssd) and also deprecated support for nss as crypto
> provider more in release notes

Then you need to replace nss with openssl, not just remove nss.
There is a better init scipt in sssd now then the one in FILESDIR

The need for:
	#Work around linker dependency problem.
	append-ldflags "-Wl,--allow-shlib-undefined"
is long gone

This 
{PCRE,CARES,SYSTEMD_LOGIN,SASL,GLIB2,DBUS,CRYPTO}_{CFLAGS,LIBS}=' '
should be
{PCRE,CARES,SYSTEMD_LOGIN,SASL,GLIB2,DBUS,CRYPTO,P11_KIT}_{CFLAGS,LIBS}=' '

You may want to consider adding:
https://github.com/SSSD/sssd/pull/5184
https://github.com/SSSD/sssd/pull/5159
Comment 3 Chris Pritchard 2020-06-08 22:46:41 UTC
Created attachment 644034 [details]
sssd-2.3.0.ebuild

Updated ebuild, includes the upstream systemd service files and a new systemd use flag. Defaults to openssl, but still buildable with nss with a use flag.

Did not apply the patches for now.
Comment 4 Larry the Git Cow gentoo-dev 2020-08-14 03:29:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3d451c1f54902d8b7a7d4e41dbd0bf501539eaac

commit 3d451c1f54902d8b7a7d4e41dbd0bf501539eaac
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2020-08-14 03:03:16 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2020-08-14 03:28:39 +0000

    sys-auth/sssd: Version bump to 2.3.1
    
    Thanks to cmvu, Joakim Tjernlund, and Chris Pritchard for the ebuild
    updates.
    
    Closes: https://bugs.gentoo.org/725396
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/package.mask           |   4 +
 sys-auth/sssd/Manifest          |   1 +
 sys-auth/sssd/metadata.xml      |   2 +-
 sys-auth/sssd/sssd-2.3.1.ebuild | 232 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 238 insertions(+), 1 deletion(-)
Comment 5 Joakim Tjernlund 2020-08-14 07:48:35 UTC
still some differences w.r.t my version
 - wbclient is deprecated and broken, will be removed soon.
 - PREFIX broken w.r.t pid dir.
 - ABI_X86="32" possibly broken, don't remember why mine is different.

Here is an diff:
@ -20,7 +28,7 @@
 	>=dev-libs/popt-1.16
 	dev-libs/glib:2
 	>=dev-libs/ding-libs-0.2
-	>=dev-libs/openssl-1.0.2
+	>=dev-libs/openssl-1.1:=
 	>=sys-libs/talloc-2.0.7
 	>=sys-libs/tdb-1.2.9
 	>=sys-libs/tevent-0.9.16
@@ -65,11 +73,15 @@
 
 CONFIG_CHECK="~KEYS"
 
 MULTILIB_WRAPPED_HEADERS=(
 	/usr/include/ipa_hbac.h
 	/usr/include/sss_idmap.h
 	/usr/include/sss_nss_idmap.h
-	/usr/include/wbclient_sssd.h
 	# --with-ifp
 	/usr/include/sss_sifp.h
 	/usr/include/sss_sifp_dbus.h
@@ -82,9 +94,6 @@
 }
 
 src_prepare() {
-	sed -i 's:#!/sbin/runscript:#!/sbin/openrc-run:' \
-		"${S}"/src/sysv/gentoo/sssd.in || die "sed sssd.in"
-
 	default
 	eautoreconf
 	multilib_copy_sources
@@ -101,6 +110,7 @@
 
 	myconf+=(
 		--localstatedir="${EPREFIX}"/var
+		--with-pid-path="${EPREFIX}"/run
 		--enable-nsslibdir="${EPREFIX}"/$(get_libdir)
 		--with-plugin-path="${EPREFIX}"/usr/$(get_libdir)/sssd
 		--enable-pammoddir="${EPREFIX}"/$(getpam_mod_dir)
@@ -109,9 +119,9 @@
 		--with-nscd
 		--with-unicode-lib="glib2"
 		--disable-rpath
+		--disable-silent-rules
 		--sbindir=/usr/sbin
 		--without-kcm
-		$(use_with samba libwbclient)
 		--with-secrets
 		$(multilib_native_use_with samba)
 		$(multilib_native_use_enable acl cifs-idmap-plugin)
@@ -157,8 +167,8 @@
 			# non-pkgconfig checks
 			ac_cv_lib_ldap_ldap_search=yes
 			--without-secrets
-			--without-libwbclient
 			--without-kcm
+			--with-crypto=""
 		)
 
 		use locator || myconf+=(
@@ -208,7 +218,7 @@
 	newins "${S}"/src/examples/logrotate sssd
 
 	newconfd "${FILESDIR}"/sssd.conf sssd
-	newinitd "${FILESDIR}"/sssd sssd
+	#newinitd "${FILESDIR}"/sssd sssd use the one in sssd
 
 	keepdir /var/lib/sss/db
 	keepdir /var/lib/sss/deskprofile
Comment 6 Joakim Tjernlund 2020-08-14 07:55:10 UTC
Please don't mask sssd just because it is under test.
Comment 7 Joakim Tjernlund 2020-08-14 07:57:24 UTC
An -9999 version would be handy as well. I got:


+MY_PV=${PV//'.'/'_'}
+if [[ ${PV} != 9999 ]]; then
+	SRC_URI="https://github.com/SSSD/sssd/releases/download/sssd-${MY_PV}/${P}.tar.gz"
+else
+	inherit git-r3
+	EGIT_REPO_URI="https://github.com/SSSD/sssd.git"
+	EGIT_BRANCH="master"
+fi
Comment 8 Joakim Tjernlund 2020-08-14 09:12:57 UTC
w.r.t masking, you did:
+# Matt Turner <mattst88@gentoo.org> (2020-08-13)
+# Masked for testing
+>=sys-auth/sssd-2.3.0

This will mask any and all sssd's >= 2.3.0 which also masks
my overlay sssd. If you really need to mask, please mask exact revision.

It is better to just remove the KEYWORDS in the ebuild instead.