Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 725268 - media-sound/audacity-2.4.2: version bump
Summary: media-sound/audacity-2.4.2: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Sound Team
URL: https://github.com/audacity/audacity/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-25 09:57 UTC by Alex
Modified: 2020-08-02 10:54 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix vertical track resizing (audacity-2.4.1-Fix-vertical-track-resizing.patch,462 bytes, patch)
2020-05-27 13:07 UTC, Alex
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2020-05-25 09:57:44 UTC
New version released

Reproducible: Always
Comment 1 Alex 2020-05-25 10:36:24 UTC
Renaming 2.3.3 ebuild and removing "fno-common" patch (as whose changes are already in the 2.4.1) works for me
Comment 2 Alex 2020-05-27 13:07:04 UTC
Correction. There were regression in 2.4.1:
https://github.com/audacity/audacity/issues/538
I propose following patch for it
Comment 3 Alex 2020-05-27 13:07:53 UTC
Created attachment 642084 [details, diff]
Fix vertical track resizing
Comment 4 Henrik Pihl 2020-07-12 23:21:18 UTC
This simple versiom bump has turned into a bigger ebuild rewrite due to upstream changes since version 2.4.0. I wanted a challenge, got it.
Per https://wiki.audacityteam.org/wiki/Building_On_Linux instructions: "Audacity's fork of wxWidgets 3.1.3 (https://github.com/audacity/wxWidgets) should be used as this includes bug fixes that are not yet available upstream."

One way would be to introduce yet another slot into x11-libs/wxGTK or are there any other (preferred) methods available, that I'm not aware of?
Comment 5 Alex 2020-07-13 18:04:01 UTC
(In reply to Henrik Pihl from comment #4)
> This simple versiom bump has turned into a bigger ebuild rewrite due to
> upstream changes since version 2.4.0. I wanted a challenge, got it.
> Per https://wiki.audacityteam.org/wiki/Building_On_Linux instructions:
> "Audacity's fork of wxWidgets 3.1.3 (https://github.com/audacity/wxWidgets)
> should be used as this includes bug fixes that are not yet available
> upstream."
> 
> One way would be to introduce yet another slot into x11-libs/wxGTK or are
> there any other (preferred) methods available, that I'm not aware of?

I suspect that they are talking about the same bug that I hackarounded with the patch above (as coincidentally I'm also the person who discovered and reported this bug). I vote for this hackaround for now. It works for now, and when proper fix will be available from wxWidgets upstream, this patch can simply be removed (and even if will be forgotten, nothing should break, because this patch just changes header inclusion order).
Comment 6 Miroslav Šulc gentoo-dev 2020-08-02 10:36:39 UTC
just working on bump to 2.4.2. also wanted to add live ebuild but that ends up with error during configuration wrt not using their fork of wxwidgets so it might be a bigger problem in the future.
Comment 7 Larry the Git Cow gentoo-dev 2020-08-02 10:54:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a8d2f6d2fd27971422031f4a8311b5317288540

commit 5a8d2f6d2fd27971422031f4a8311b5317288540
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2020-08-02 10:54:24 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2020-08-02 10:54:41 +0000

    media-sound/audacity: bump to 2.4.2 + switched to cmake
    
    Closes: https://bugs.gentoo.org/725268
    Package-Manager: Portage-3.0.1, Repoman-2.3.23
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/audacity/Manifest                      |   2 +
 media-sound/audacity/audacity-2.4.2.ebuild         | 124 +++++++++++++++++++++
 .../files/audacity-2.4.2-fix-gettimeofday.patch    |  12 ++
 .../files/audacity-2.4.2-fix-metainfo.patch        |  12 ++
 ...udacity-2.4.2-fix-vertical-track-resizing.patch |  14 +++
 media-sound/audacity/metadata.xml                  |   2 +
 6 files changed, 166 insertions(+)