Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 725134 - media-libs/x265-3.3: does not build on ppc64
Summary: media-libs/x265-3.3: does not build on ppc64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-25 04:02 UTC by Georgy Yakovlev
Modified: 2020-05-25 05:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2020-05-25 04:02:18 UTC
due to changes in ebuild in 3.3 and the way how asm is handled it's impossible to build on ppc64.

there are some key points

1) altivec can't be enabled unless power8 is enabled. that's why ebuild used -DENABLE_ALTIVEC=$(usex power8 ON OFF), it was not a mistake.

2) asm=altivec on ppc64 for this package (#if defined(ENABLE_ASSEMBLY) || HAVE_ALTIVEC

3) I don't think you can build 10 and 12bit variants with altivec at all, but this needs checking. https://bugs.gentoo.org/607802#c5


but due to the way how changed ebuild adds cmake args it's impossible to override altivec for 10 and 12bit builds, as the main function will append use-controlled flags.

working on a patch.
Comment 1 Georgy Yakovlev archtester gentoo-dev 2020-05-25 05:11:16 UTC
after some digging I figured it's actually possible to build altivec and power8 separately.

comitting fix. moved some code around to apply ppc specifics for different variants.

and disabled asm via useflag skipping.
Comment 2 Larry the Git Cow gentoo-dev 2020-05-25 05:11:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e0a5fb99616c7abe00edac7e36d6c61e4af3318

commit 8e0a5fb99616c7abe00edac7e36d6c61e4af3318
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-05-25 05:01:41 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-05-25 05:09:15 +0000

    media-libs/x265: fix 3.3 on ppc64
    
    Closes: https://bugs.gentoo.org/725134
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 media-libs/x265/x265-3.3.ebuild | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe5c3453d9b642af66fbbc09c9b0e844034bc21f

commit fe5c3453d9b642af66fbbc09c9b0e844034bc21f
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-05-25 05:02:39 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-05-25 05:09:58 +0000

    media-libs/x265: sync live ebuild
    
    Bug: https://bugs.gentoo.org/725134
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 media-libs/x265/x265-9999.ebuild | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)