Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 723518 - app-crypt/tpm2-tss-2.4.0: ebuild has fapi as required USE
Summary: app-crypt/tpm2-tss-2.4.0: ebuild has fapi as required USE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Christopher Byrne
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-05-17 23:06 UTC by Petronio Coelho
Modified: 2020-05-18 05:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petronio Coelho 2020-05-17 23:06:08 UTC 
app-crypt/tpm2-tss-2.4.0 added the fapi USE, but it appears there was a mistake in REQUIRED_USE making it mandatory.

From tpm2-tss.2.4.0.ebuild:

REQUIRED_USE="^^ ( gcrypt openssl )
                fapi ( !gcrypt )"


Likely should add a ? after fapi to make it optional.

Reproducible: Always
Comment 1 Brian Evans (RETIRED) gentoo-dev 2020-05-17 23:12:32 UTC 
Ideally this should be "fapi? ( openssl !gcrypt )" to avoid a user issue after the fact
Comment 2 Larry the Git Cow gentoo-dev 2020-05-18 05:00:41 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc9b2740db655af9771048cf8c8de8ce04648cf7

commit fc9b2740db655af9771048cf8c8de8ce04648cf7
Author:     Salah Coronya <salah.coronya@gmail.com>
AuthorDate: 2020-05-17 23:25:47 +0000
Commit:     Jason A. Donenfeld <zx2c4@gentoo.org>
CommitDate: 2020-05-18 04:59:54 +0000

    app-crypt/tpm2-tss: Fix required USE flags
    
    Closes: https://bugs.gentoo.org/723518
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Salah Coronya <salah.coronya@gmail.com>
    Signed-off-by: Jason A. Donenfeld <zx2c4@gentoo.org>

 app-crypt/tpm2-tss/tpm2-tss-2.4.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)