dolphin now requires zstd, which no standard FindZSTD.cmake exists for, so it fails to find it. Reproducible: Always Steps to Reproduce: 1. emerge games-emulation/dolphin-9999 Actual Results: fails to build Expected Results: builds CMake Warning at CMakeLists.txt:611 (find_package): By not providing "Findzstd.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "zstd", but CMake did not find one. Could not find a package configuration file provided by "zstd" with any of the following names: zstdConfig.cmake zstd-config.cmake Add the installation prefix of "zstd" to CMAKE_PREFIX_PATH or set "zstd_DIR" to a directory containing one of the above files. If "zstd" provides a separate development package or SDK, be sure it has been installed. -- Shared zstd not found, falling back to the static library CMake Error at CMakeLists.txt:617 (add_subdirectory): add_subdirectory given source "Externals/zstd" which is not an existing directory.
Looking at CMakeLists.txt it ought to try to find libzstd: """ find_package(zstd) if(ZSTD_FOUND) message(STATUS "Using shared zstd") else() check_vendoring_approved(zstd) message(STATUS "Shared zstd not found, falling back to the static library") add_subdirectory(Externals/zstd) endif() """ But something is off. Looking.
Ah, it actually misses a bit of code like https://github.com/facebook/rocksdb/blob/master/cmake/modules/Findzstd.cmake. Let's use bundled copy for now.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5d0bdbb7b11186afcc616967a8dc57369dd9555 commit e5d0bdbb7b11186afcc616967a8dc57369dd9555 Author: Sergei Trofimovich <slyfox@gentoo.org> AuthorDate: 2020-05-15 23:06:49 +0000 Commit: Sergei Trofimovich <slyfox@gentoo.org> CommitDate: 2020-05-15 23:12:14 +0000 games-emulation/dolphin: allow bundled zstd dolphin lacks zstd discovery code. Let's use bundled code for now. Reported-by: Michael Cook Closes: https://bugs.gentoo.org/723276 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> games-emulation/dolphin/dolphin-9999.ebuild | 2 ++ 1 file changed, 2 insertions(+)
