Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 723250 - net-mail/queue-repair: python3 support patch
Summary: net-mail/queue-repair: python3 support patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: py3-tracker, python-3-incompatible
  Show dependency tree
 
Reported: 2020-05-15 14:55 UTC by David Heidelberg (okias)
Modified: 2020-09-04 15:52 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
files/python3.patch (python3.patch,8.26 KB, patch)
2020-05-17 16:46 UTC, Alex Efros
Details | Diff
queue-repair-0.9.0-r2.ebuild (queue-repair-0.9.0-r2.ebuild,759 bytes, text/plain)
2020-05-17 16:47 UTC, Alex Efros
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Heidelberg (okias) 2020-05-15 14:55:11 UTC
https://notes.sagredo.eu/en/qmail-notes-185/queue-repair-21.html#comment1506

this patch makes code python3 compliant.

Is there someone who will merge my PR, when I send it with Python 3 support?

Reproducible: Always
Comment 1 Jonas Stein gentoo-dev 2020-05-15 22:34:42 UTC
You can prepare a PR on github. We can help you how to prepare/format it properly.
You can ask on IRC #gentoo-dev-help

Ideally it should be pushed upstream and fixed there. 
I sent a mail to the author and will report here about the outcome.
Perhaps he is willing to push the source to a repository where you can send you patches to.
Comment 2 Alex Efros 2020-05-17 16:46:26 UTC
Created attachment 639852 [details, diff]
files/python3.patch

I've fixed patch referenced in comment #0.
Comment 3 Alex Efros 2020-05-17 16:47:28 UTC
Created attachment 639854 [details]
queue-repair-0.9.0-r2.ebuild
Comment 4 David Heidelberg (okias) 2020-05-18 07:11:24 UTC
(In reply to Alex Efros from comment #3)
> Created attachment 639854 [details]
> queue-repair-0.9.0-r2.ebuild

Hello Alex,

thanks for effort, do you plan to send it as Pull request? In case yes, feel free to mention it here :) (or add Closes: https://bugs.gentoo.org/723250 tag)
Comment 5 Alex Efros 2020-05-18 19:14:52 UTC
(In reply to David Heidelberg (okias) from comment #4)
> thanks for effort, do you plan to send it as Pull request? In case yes, feel
> free to mention it here :) (or add Closes: https://bugs.gentoo.org/723250
> tag)

TBH I've not really good experience with Gentoo PRs as a proxy-maintainer - they often hangs for months, sometimes without review, sometimes after review and with my questions asked… I understand it's open source, no one have to review and decide PRs timely, but… all of this makes me feel work on PRs a bit useless. In short, I'm really disappointed.

Unlike PRs, information attached to bugs turns out to be very useful - easy to find, download and apply to local system.

I'm using Gentoo since 2004, but my experience may be limited, or it may works this way because something is wrong with me or my PRs - sure, that's possible.

Anyway… sure, I'll open PR, no prob. Just don't be surprised if this won't change anything.
Comment 6 Jonas Stein gentoo-dev 2020-05-21 21:26:35 UTC
I sent a mail to upstream who was thankful and is going to look into the patch soon.
I think a fix upstream is the best solution.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-08-16 10:55:53 UTC
ping.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-09-01 05:49:30 UTC
@dakon, would you like to take care of it?
Comment 9 Larry the Git Cow gentoo-dev 2020-09-04 15:52:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=263e74d27b2f17fe2ed00b0fb4a66d0354ee0808

commit 263e74d27b2f17fe2ed00b0fb4a66d0354ee0808
Author:     Rolf Eike Beer <eike@sf-mail.de>
AuthorDate: 2020-09-04 15:10:43 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-09-04 15:52:53 +0000

    net-mail/queue-repair: "port" it to python3
    
    Closes: https://bugs.gentoo.org/723250
    Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
    Closes: https://github.com/gentoo/gentoo/pull/17414
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 net-mail/queue-repair/queue-repair-0.9.0-r2.ebuild | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)