Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 722560 - app-admin/syslog-summary lost gzip support (suggesting sys-apps/file[python] is useless)
Summary: app-admin/syslog-summary lost gzip support (suggesting sys-apps/file[python] ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Paul Healy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-05-11 23:49 UTC by Daniel M. Weeks
Modified: 2020-06-28 10:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel M. Weeks 2020-05-11 23:49:04 UTC
app-admin/syslog-summary has a "soft dependency" on sys-apps/file[python] for gzip support. Since it's python2_7 only and that python target has been dropped from sys-apps/file, it doesn't make sense to suggest installing it.

Reproducible: Always
Comment 1 Paul Healy 2020-06-21 11:30:33 UTC
Thanks Daniel - fixed with https://github.com/gentoo/gentoo/pull/16360
Comment 2 Joonas Niilola gentoo-dev 2020-06-25 11:50:51 UTC
Not fixed before it's merged. You've used the "Closes:" tag correctly in the git summary, it will close this bug automatically when it's merged.

We need to keep the bug open before doing so, because other people might be looking for it.
Comment 3 Larry the Git Cow gentoo-dev 2020-06-28 10:41:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=45a0856880a4292e8592e7dba2b3165c312e0482

commit 45a0856880a4292e8592e7dba2b3165c312e0482
Author:     Paul Healy <lmiphay@gmail.com>
AuthorDate: 2020-06-21 11:27:35 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-06-28 10:40:58 +0000

    app-admin/syslog-summary: remove file magic dep
    
    Replace the soft dep on sys-apps/file (magic module) with the existing fallback file suffix check
    Remove the sys-apps/file[python] suggestion in pkg_postinst
    
    Closes: https://bugs.gentoo.org/722560
    Signed-off-by: Paul Healy <lmiphay@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16360
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../syslog-summary-1.14-remove-file-magic.patch    | 35 ++++++++++++++++++
 .../syslog-summary/syslog-summary-1.14-r4.ebuild   | 42 ++++++++++++++++++++++
 2 files changed, 77 insertions(+)