Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 722186 - =media-libs/glfw-3.3.1 need to depend on x11-libs/libXi
Summary: =media-libs/glfw-3.3.1 need to depend on x11-libs/libXi
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-10 17:13 UTC by Bernd
Modified: 2020-06-16 14:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
glfw-3.3.1:20200510-170000.log (glfw-3.3.1:20200510-170000.log,3.53 KB, text/plain)
2020-05-10 17:16 UTC, Bernd
Details
emerge-info-glfw-3.3.1.txt (emerge-info-glfw-3.3.1.txt,6.54 KB, text/plain)
2020-05-10 17:18 UTC, Bernd
Details
0001-media-libs-glfw-add-missing-dependency.patch (0001-media-libs-glfw-add-missing-dependency.patch,858 bytes, patch)
2020-05-14 05:21 UTC, Bernd
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd 2020-05-10 17:13:47 UTC
When wayland USE flag is not set, glfw needs the XInput.h header file. After installing x11-libs/libXi, the ebuild succeeds.

Reproducible: Always

Steps to Reproduce:
1. USE="-wayland" emerge =glfw-3.3.1
2.
3.



Build log and emerge --info as attachments.
Comment 1 Bernd 2020-05-10 17:16:47 UTC
Created attachment 637682 [details]
glfw-3.3.1:20200510-170000.log

build log
Comment 2 Bernd 2020-05-10 17:18:05 UTC
Created attachment 637684 [details]
emerge-info-glfw-3.3.1.txt

output of emerge --info

Note, the build happened in a test chroot, with almost only stage3 installed.
Comment 3 Bernd 2020-05-14 05:21:48 UTC
Created attachment 638682 [details, diff]
0001-media-libs-glfw-add-missing-dependency.patch

This patch to the 3.3.1 ebuild solves the issue.
Comment 4 Stefan Strogin gentoo-dev 2020-06-16 09:57:39 UTC
It's odd, but glfw is not linked against libXi. Yet it needs the header X11/extensions/XInput2.h.
I'll add x11-libs/libXi to BDEPEND.
Comment 5 Larry the Git Cow gentoo-dev 2020-06-16 10:39:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3514eef209b0c22c422ef3ea015f75f188f039ee

commit 3514eef209b0c22c422ef3ea015f75f188f039ee
Author:     Max Audron <audron@cocaine.farm>
AuthorDate: 2020-06-15 13:27:54 +0000
Commit:     Stefan Strogin <steils@gentoo.org>
CommitDate: 2020-06-16 10:35:57 +0000

    media-libs/glfw: version bump to 3.3.2
    
    Signed-off-by: Max Audron <audron@cocaine.farm>
    
    Add x11-libs/libXi to BDEPEND because glfw needs XInput2.h for
    compilation, but does not link against libXi.so.
    
    Closes: https://bugs.gentoo.org/722186
    Closes: https://github.com/gentoo/gentoo/pull/16257
    Signed-off-by: Stefan Strogin <steils@gentoo.org>

 media-libs/glfw/Manifest          |  1 +
 media-libs/glfw/glfw-3.3.2.ebuild | 48 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+)
Comment 6 Larry the Git Cow gentoo-dev 2020-06-16 14:33:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab46580d900aec6a1627f1fad4f41890fbbd88db

commit ab46580d900aec6a1627f1fad4f41890fbbd88db
Author:     Stefan Strogin <steils@gentoo.org>
AuthorDate: 2020-06-16 14:30:51 +0000
Commit:     Stefan Strogin <steils@gentoo.org>
CommitDate: 2020-06-16 14:32:37 +0000

    media-libs/glfw: move x11-libs/libXi from BDEPEND to DEPEND
    
    When cross-compiling, these headers should be on CHOST, not CBUILD.
    
    Bug: https://bugs.gentoo.org/722186
    Package-Manager: Portage-2.3.101, Repoman-2.3.22
    Signed-off-by: Stefan Strogin <steils@gentoo.org>

 media-libs/glfw/glfw-3.3.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)