Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 722114 - xfce-extra/xfce4-power-manager doesn't depend on pm-utils
Summary: xfce-extra/xfce4-power-manager doesn't depend on pm-utils
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-10 12:20 UTC by Esteve Varela Colominas
Modified: 2020-10-08 20:57 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Esteve Varela Colominas 2020-05-10 12:20:02 UTC
Currently, all versions of xfce-extra/xfce4-power-manager are set to depend on pm-utils. However, this hasn't been the case in a long time.

When suspending or hibernating, the package does the following[1]:
- Use logind if available
- If using an old version (<0.99.0, ancient!) of UPower, use that
- Use ConsoleKit2 if available, which calls upon pm-utils
- Use "built-in" fallback with policykit[2], which calls upon pm-utils[3]. This is the _only_ case in which pm-utils might be used!

This is an either-or relationship, where on any default gentoo system before the profile switch to elogind ConsoleKit2 would've been used, which indirectly uses pm-utils, but never directly. Installing (e)logind completely voids the runtime dependency.

It'd be nice if this dependency was completely removed, or made softer through a "one-of" dependency consisting of pm-utils, consolekit, elogind and systemd, or a virtual package with the same.

This would also solve https://bugs.gentoo.org/670912

[1]: https://github.com/xfce-mirror/xfce4-power-manager/blob/master/src/xfpm-power.c#L447
[2]: https://github.com/xfce-mirror/xfce4-power-manager/blob/master/src/xfpm-suspend.c#L191
[3]: https://github.com/xfce-mirror/xfce4-power-manager/blob/master/src/xfpm-pm-helper.c#L72
Comment 1 Andreas Sturmlechner gentoo-dev 2020-05-10 12:26:00 UTC
I guess if no one wants to comment in bug 670912 itself...
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-10-08 20:57:36 UTC
commit 34260b21a81f95de61c656a35643553d000de70e
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-10-08 22:56:13 +0200
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-10-08 22:57:12 +0200

    xfce-extra/xfce4-power-manager: Remove unnecessary dep on pm-utils
    
    pm-utils are used only as a last resort fallback for suspend/hibernate
    support.  The preferred provider for these functions is logind.
    However, both are entirely optional runtime deps, so just report missing
    logind in postinst.
    
    Signed-off-by: Michał Górny <mgorny@gentoo.org>