Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 721896 - app-arch/xdms fails to compile (`Unpack_HEAVY': u_heavy.c:(.text+0x92): undefined reference to `decode_c')
Summary: app-arch/xdms fails to compile (`Unpack_HEAVY': u_heavy.c:(.text+0x92): undef...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
: 721994 743376 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-09 16:55 UTC by Agostino Sarubbo
Modified: 2021-04-26 15:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,11.97 KB, text/plain)
2020-05-09 16:55 UTC, Agostino Sarubbo
Details
Change inline to static functions for decode_c and decode_p (inline_fix.patch,656 bytes, patch)
2021-04-21 19:31 UTC, Roman 'gryf' Dobosz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-05-09 16:55:10 UTC
This is an auto-filled bug because app-arch/xdms fails to compile.
The issue was originally discovered on amd64, but it may be reproducible on other arches as well.
If you think that a different summary clarifies the issue better, feel free to change it.
Attached build log and emerge --info.
Comment 1 Agostino Sarubbo gentoo-dev 2020-05-09 16:55:18 UTC
Created attachment 637110 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2020-06-22 08:15:13 UTC
*** Bug 721994 has been marked as a duplicate of this bug. ***
Comment 3 Agostino Sarubbo gentoo-dev 2021-02-23 09:31:50 UTC
*** Bug 743376 has been marked as a duplicate of this bug. ***
Comment 4 Larry the Git Cow gentoo-dev 2021-04-18 01:38:40 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5a1059bbb719c64407f073cf3c194792ff68027

commit c5a1059bbb719c64407f073cf3c194792ff68027
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-04-17 01:51:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-18 01:38:20 +0000

    app-arch/xdms: respect DESTDIR, fix man dest, Darwin build
    
    * EAPI 6->7
    * Respect DESTDIR (similar patch to app-arch/cksfv, naturally)
    * Fix VariableScope issue (${ED} in src_configure, see point 1)
    * Fix man page destination
    * Fix build on Darwin (append standard undefined lookup flag)
    
    Bug: https://bugs.gentoo.org/721896
    Signed-off-by: Sam James <sam@gentoo.org>

 app-arch/cksfv/cksfv-1.3.15.ebuild                 |  2 +-
 .../files/xdms-1.3.2-dont-compress-man-pages.patch | 13 +++++++
 .../xdms/files/xdms-1.3.2-respect-DESTDIR.patch    | 22 ++++++++++++
 app-arch/xdms/xdms-1.3.2-r1.ebuild                 | 31 -----------------
 app-arch/xdms/xdms-1.3.2-r2.ebuild                 | 40 ++++++++++++++++++++++
 5 files changed, 76 insertions(+), 32 deletions(-)
Comment 5 Roman 'gryf' Dobosz 2021-04-21 19:30:07 UTC
I noticed, that xdms uses inline decode functions while gcc complains with non-static character of those. I've attached patch, which make compilation possible, and test it briefly. The only thing, which doesn't work was x command (extract files) which require 'readdisk' command (it doesn't worked before anyway).
Comment 6 Roman 'gryf' Dobosz 2021-04-21 19:31:03 UTC
Created attachment 701544 [details, diff]
Change inline to static functions for decode_c and decode_p
Comment 7 Agostino Sarubbo gentoo-dev 2021-04-21 20:38:47 UTC
Hello, thanks for the patch. I believe you can speed up the process by making a pull-request via Github.
Comment 8 Larry the Git Cow gentoo-dev 2021-04-26 15:50:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aae03c0fdc38634ec8804af63c685828b6e820bf

commit aae03c0fdc38634ec8804af63c685828b6e820bf
Author:     Roman Dobosz <gryf73@gmail.com>
AuthorDate: 2021-04-26 13:32:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-26 15:49:53 +0000

    app-arch/xdms: fix build issues with GCC 10.
    
    Patch origins from Debian.
    
    Signed-off-by: Roman Dobosz <gryf73@gmail.com>
    Bug: https://bugs.gentoo.org/721896
    Closes: https://github.com/gentoo/gentoo/pull/20548
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/xdms-1.3.2-fix-build-with-gcc-10.patch   | 80 ++++++++++++++++++++++
 app-arch/xdms/xdms-1.3.2-r2.ebuild                 |  1 +
 2 files changed, 81 insertions(+)
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-26 15:53:12 UTC
Thanks!