Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 721876 - dev-qt/qtwebengine: src/3rdparty/chromium/third_party/perfetto/include/perfetto/base/task_runner.h:48:55: error: 'uint32_t' has not been declared
Summary: dev-qt/qtwebengine: src/3rdparty/chromium/third_party/perfetto/include/perfet...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
: 722220 723010 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-09 15:24 UTC by Duncan
Modified: 2020-09-25 07:56 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info qtwebengine (emerge.qtwebengine.info,8.67 KB, text/plain)
2020-05-09 15:24 UTC, Duncan
Details
failing build log (xz-ed to fit) (dev-qt:qtwebengine-5.15.0_rc:20200509-123341.log.xz,111.63 KB, application/x-xz)
2020-05-09 17:14 UTC, Duncan
Details
qtwebengine-5.14.2-gcc-10-build.patch (qtwebengine-5.14.2-gcc-10-build.patch,3.02 KB, patch)
2020-05-10 04:59 UTC, Chiitoo
Details | Diff
dev-qt-qtwebengine-5.15.0_rc2:20200514-123356.log (dev-qt:qtwebengine-5.15.0_rc2:20200514-123356.log,207.47 KB, text/x-log)
2020-05-14 12:56 UTC, Andreas Sturmlechner
Details
qtwebengine-5.14.2-gcc-10-build.patch (qtwebengine-5.14.2-gcc-10-build.patch,3.53 KB, patch)
2020-05-14 17:12 UTC, Chiitoo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2020-05-09 15:24:37 UTC
Created attachment 637064 [details]
emerge --info qtwebengine

After merging gcc-10.1.0 and eselecting to it today, I continued with my usual updates, including the new qt 5.15.0_rc from the qt overlay.  All of the new qt packages (well, that I have installed) merged fine except for qtwebengine-5.15.0_rc.  After eselecting back to gcc-9.3.0 it seems to be building fine (still building but way past the problem with gcc-10.1 and the betas built with gcc-9.3 were installed previously), so the problem appears to be triggered by gcc-10.1.0.

USE="alsa bindist jumbo-build system-ffmpeg system-icu widgets -debug -designer -geolocation -kerberos -pulseaudio -test"

FAILED: obj/third_party/perfetto/src/base/base/virtual_destructors.o
[...]
In file included from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/src/base/virtual_destructors.cc:17:
../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/base/task_runner.h:48:55: error: 'uint32_t' has not been declared
48 |   virtual void PostDelayedTask(std::function<void()>, uint32_t delay_ms) = 0;
|                                                       ^~~~~~~~

[...]

FAILED: obj/third_party/perfetto/src/base/base/unix_task_runner.o
[...]
In file included from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/ext/base/unix_task_runner.h:21,
from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/src/base/unix_task_runner.cc:20:
../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/base/task_runner.h:48:55: error: 'uint32_t' has not been declared
48 |   virtual void PostDelayedTask(std::function<void()>, uint32_t delay_ms) = 0;
|                                                       ^~~~~~~~
In file included from ../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/src/base/unix_task_runner.cc:20:
../../../../qtwebengine-everywhere-src-5.15.0-rc/src/3rdparty/chromium/third_party/perfetto/include/perfetto/ext/base/unix_task_runner.h:69:8: error: 'void perfetto::base::UnixTaskRunner::PostDelayedTask(std::function<void()>, uint32_t)' marked 'override', but does not override
69 |   void PostDelayedTask(std::function<void()>, uint32_t delay_ms) override;
|        ^~~~~~~~~~~~~~~

[...]

ninja: build stopped: subcommand failed.
make[3]: *** [Makefile.gn_run:543: run_ninja] Error 1
make[3]: Leaving directory '/tmp/portage/dev-qt/qtwebengine-5.15.0_rc/work/qtwebengine-everywhere-src-5.15.0-rc_build/src/core'
make[2]: *** [Makefile:82: sub-gn_run-pro-make_first] Error 2

emerge --info qtwebengine attached, full build failure log to be attached.
Comment 1 Duncan 2020-05-09 17:14:44 UTC
Created attachment 637132 [details]
failing build log (xz-ed to fit)
Comment 2 cyshei 2020-05-09 18:51:31 UTC
Same issue also exists in the non-overlay 5.14.2 with GCC 10 as well.
Comment 3 Stefan de Konink 2020-05-09 20:46:06 UTC
While using jumbo build, I also see a failure on 5.14.2 with GCC. When trying to compile with CC=clang CXX=clang++ it fails in a different position.
Comment 4 Chiitoo gentoo-dev 2020-05-10 02:19:07 UTC
Yep, this is already fixed upstream [1], and can probably be backported quick-like.

1. https://code.qt.io/cgit/qt/qtwebengine-chromium.git/commit/?h=80-based&id=eaf11e78ea
Comment 5 Chiitoo gentoo-dev 2020-05-10 04:59:11 UTC
Created attachment 637246 [details, diff]
qtwebengine-5.14.2-gcc-10-build.patch
Comment 6 Larry the Git Cow gentoo-dev 2020-05-10 05:40:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=a127863585a1407e549afb7e92f8f0ca355cb109

commit a127863585a1407e549afb7e92f8f0ca355cb109
Author:     Jimi Huotari <chiitoo@gentoo.org>
AuthorDate: 2020-05-10 04:17:21 +0000
Commit:     Jimi Huotari <chiitoo@gentoo.org>
CommitDate: 2020-05-10 04:46:43 +0000

    dev-qt/qtwebengine: fix build with GCC-10
    
    Bug: https://bugs.gentoo.org/721876
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>

 .../files/qtwebengine-5.15.0-gcc-10-build.patch    | 64 ++++++++++++++++++++++
 dev-qt/qtwebengine/qtwebengine-5.15.0_rc.ebuild    |  1 +
 2 files changed, 65 insertions(+)
Comment 7 Chiitoo gentoo-dev 2020-05-13 06:41:12 UTC
*** Bug 722220 has been marked as a duplicate of this bug. ***
Comment 8 Andreas Sturmlechner gentoo-dev 2020-05-14 12:56:03 UTC
Created attachment 638920 [details]
dev-qt-qtwebengine-5.15.0_rc2:20200514-123356.log

Fix is not enough for 5.15.0_rc2.
Comment 9 Andreas Sturmlechner gentoo-dev 2020-05-14 14:08:39 UTC
*** Bug 723010 has been marked as a duplicate of this bug. ***
Comment 10 Chiitoo gentoo-dev 2020-05-14 14:59:09 UTC
(In reply to Andreas Sturmlechner from comment #8)
> Created attachment 638920 [details]
> dev-qt-qtwebengine-5.15.0_rc2:20200514-123356.log
> 
> Fix is not enough for 5.15.0_rc2.

https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/300434
Comment 11 Chiitoo gentoo-dev 2020-05-14 17:12:33 UTC
Created attachment 639068 [details, diff]
qtwebengine-5.14.2-gcc-10-build.patch

Now with more <string> include.
Comment 12 Andreas Sturmlechner gentoo-dev 2020-05-14 17:21:52 UTC
Thanks, fixed in 63b27c3c.
Comment 13 Pavel Volkov 2020-05-15 07:13:12 UTC
task_runner.h is patched, still

src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.cc

is not patched:

In file included from ../../../../qtwebengine-everywhere-src-5.14.2/src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.cc:11:
../../../../qtwebengine-everywhere-src-5.14.2/src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.h:29:16: error: ‘uint16_t’ does not name a type
   29 |   static const uint16_t kNumRefBits = 7;
      |                ^~~~~~~~
Comment 14 Dmytro 'daks' Fomenko 2020-05-15 23:32:45 UTC
@Pavel Volkov probably you need to add '#include <stdint.h>' to src/3rdparty/chromium/third_party/webrtc/modules/video_coding/decoding_state.h
Comment 15 Chiitoo gentoo-dev 2020-05-16 00:45:17 UTC
Yes, replacing 'qtwebengine-5.14.2-gcc-10-{1,2}.patch' with the one I attached here should work.
Comment 16 Larry the Git Cow gentoo-dev 2020-05-17 08:18:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=459a1fb8aa74947e214661bbd5cbebcaed8ece17

commit 459a1fb8aa74947e214661bbd5cbebcaed8ece17
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-05-17 08:16:10 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-05-17 08:16:54 +0000

    dev-qt/qtwebengine: Update gcc-10.patch
    
    Additionally includes patch to decoding_state.h.
    
    Thanks-to: Jimi Huotari <chiitoo@gentoo.org>
    Bug: https://bugs.gentoo.org/721876
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/qtwebengine-5.14.2-gcc-10-2.patch        | 27 ----------------
 ...-10-1.patch => qtwebengine-5.14.2-gcc-10.patch} | 37 ++++++++++++++++++----
 dev-qt/qtwebengine/qtwebengine-5.14.2.ebuild       |  4 +--
 3 files changed, 33 insertions(+), 35 deletions(-)