Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 721794 - app-antivirus/fangfrisch fails tests
Summary: app-antivirus/fangfrisch fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ralph Seichter
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 721530
  Show dependency tree
 
Reported: 2020-05-09 07:37 UTC by Agostino Sarubbo
Modified: 2020-05-15 20:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,24.56 KB, text/plain)
2020-05-09 07:37 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2020-05-09 07:37:50 UTC
This is an auto-filled bug because app-antivirus/fangfrisch fails tests.
The issue was originally discovered on x86, but it may be reproducible on other arches as well.
If you think that a different summary clarifies the issue better, feel free to change it.
Attached build log and emerge --info.
Comment 1 Agostino Sarubbo gentoo-dev 2020-05-09 07:37:56 UTC
Created attachment 636932 [details]
build.log

build log and emerge --info
Comment 2 Ralph Seichter 2020-05-09 13:44:18 UTC
Based on the nature of Fangfrisch, many unittests require network access, and the build host apparently does not provide it:

> Temporary failure in name resolution

The tests all work, both in my development environment and in GitHub CI; see for example https://github.com/rseichter/fangfrisch/runs/564610734?check_suite_focus=true .
Comment 3 Agostino Sarubbo gentoo-dev 2020-05-10 08:12:14 UTC
Network access should not be present in src_test, so you have to find a solution to workaround (disable those tests?)
Comment 4 Ralph Seichter 2020-05-10 12:22:45 UTC
Pick and choose does not seem useful. I could disable tests altogether. However, that would mean opening a PR and waiting for it to be processed, which can take a while and would further delay the stabilisation request #721530.

Can you continue stabilisation as the ebuild is now, and when the next Fangfrisch release happens, I can restrict the tests for that new release's ebuild?
Comment 5 Larry the Git Cow gentoo-dev 2020-05-15 20:13:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c10a0883a161b7ca01c27c3d65abdc7a424430be

commit c10a0883a161b7ca01c27c3d65abdc7a424430be
Author:     Ralph Seichter <github@seichter.de>
AuthorDate: 2020-05-12 14:05:14 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2020-05-15 20:13:08 +0000

    app-antivirus/fangfrisch: Disable unit tests
    
    Due to the nature of Fangfrisch, most tests require network connectivity.
    Upstream CI reports show that the tests are successful, so instead of a
    pick-and-choose approach, the complete tests directory is removed in
    this ebuild.
    
    Closes: https://bugs.gentoo.org/721794
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Ralph Seichter <gentoo@seichter.de>
    Closes: https://github.com/gentoo/gentoo/pull/15765
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 .../fangfrisch/fangfrisch-1.2.0-r1.ebuild          | 69 ++++++++++++++++++++++
 1 file changed, 69 insertions(+)