Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 721732 - media-video/dvdbackup-0.4.2 compile failure with media-libs/libdvdread-6.1.0
Summary: media-video/dvdbackup-0.4.2 compile failure with media-libs/libdvdread-6.1.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
: 722004 748599 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-09 02:22 UTC by Christohper Harrington
Modified: 2020-10-15 10:02 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Failing build log (build.log,9.40 KB, text/plain)
2020-05-09 02:22 UTC, Christohper Harrington
Details
Patch from Launchpad (with whitespace fixed) (libdvdread-6.1.0.diff,2.77 KB, patch)
2020-05-09 03:44 UTC, Christohper Harrington
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christohper Harrington 2020-05-09 02:22:52 UTC
Created attachment 636920 [details]
Failing build log

With libdvdread-6.0.2, dvdbackup-0.4.2 compiles successfully. With libdvdread-6.1.0, dvdbackup-0.4.2 compile fails with a missing structure member.

dvdbackup.c: In function 'DVDCopyIfoBup':
dvdbackup.c:1212:29: error: 'ifo_handle_t' {aka 'struct <anonymous>'} has no member named 'file'
 1212 |  size = DVDFileSize(ifo_file->file) * DVD_VIDEO_LB_LEN;
      |                             ^~
dvdbackup.c:1223:22: error: 'ifo_handle_t' {aka 'struct <anonymous>'} has no member named 'file'
 1223 |  DVDFileSeek(ifo_file->file, 0);
      |                      ^~
dvdbackup.c:1225:27: error: 'ifo_handle_t' {aka 'struct <anonymous>'} has no member named 'file'
 1225 |  if (DVDReadBytes(ifo_file->file,buffer,size) != size) {
      |                           ^~


$ emerge --info dvdbackup
Portage 2.3.99 (python 3.7.7-final-0, default/linux/amd64/17.1/no-multilib, gcc-9.3.0, glibc-2.31-r2, 5.6.10-gentoo-shore x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.6.10-gentoo-shore-x86_64-AMD_Ryzen_7_1700_Eight-Core_Processor-with-gentoo-2.7
KiB Mem:    32763248 total,  23646428 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Fri, 08 May 2020 21:30:01 +0000
Head commit of repository gentoo: fcf660f89dc8bb14d39e8b1d601f41dcbfdb1ada
sh bash 5.0_p17
ld GNU ld (Gentoo 2.34 p1) 2.34.0
app-shells/bash:          5.0_p17::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.2::gentoo
dev-lang/python:          2.7.18::gentoo, 3.6.10-r2::gentoo, 3.7.7-r2::gentoo, 3.8.2-r2::gentoo
dev-util/cmake:           3.17.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.69-r5::gentoo
sys-devel/automake:       1.16.2::gentoo
sys-devel/binutils:       2.34::gentoo
sys-devel/gcc:            8.4.0::gentoo, 9.3.0::gentoo, 10.1.0::gentoo
sys-devel/gcc-config:     2.2.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.6::gentoo (virtual/os-headers)
sys-libs/glibc:           2.31-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts:

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--jobs=3 --complete-graph --with-bdeps=y"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j20"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 berkdb bzip2 cli crypt dri dvd fdk fortran gdbm iconv ipv6 jpeg json libtirpc lzo ncurses nfsv41 nptl openmp pcre pcre16 png python readline seccomp split-usr sqlite ssl syslog tcpd udev unicode uuid x264 xattr xml yaml zlib" ABI_X86="64" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GRUB_PLATFORMS="efi-64 pc" INPUT_DEVICES="void" KERNEL="linux" L10N="en en-US" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby25 ruby27 ruby26" USERLAND="GNU" VIDEO_CARDS="dummy"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

media-video/dvdbackup-0.4.2::gentoo was built with the following:
USE="-nls"
Comment 1 Christohper Harrington 2020-05-09 02:28:16 UTC
Looks like this commit is the breaking change:
https://code.videolan.org/videolan/libdvdread/-/commit/cabd80c8350bc22a9c705363565e8631ecb39234
Comment 2 Christohper Harrington 2020-05-09 02:52:35 UTC
Launchpad bug added to See Also with possible patch?
Comment 3 Christohper Harrington 2020-05-09 03:44:00 UTC
Created attachment 636924 [details, diff]
Patch from Launchpad (with whitespace fixed)

This is the patch from the Launchpad bug after adjusting whitespace. This file placed in /etc/portage/patches/media-video/dvdbackup-0.4.2/ allows compile to succeed.
Comment 4 Christohper Harrington 2020-05-09 17:15:31 UTC
Actual original patch by Felix Palmen via FreeBSD bugzilla.
Comment 5 Matt Whitlock 2020-05-14 19:54:06 UTC
Confirming the referenced patch fixes the build failure for me on ~amd64.
Comment 6 Christohper Harrington 2020-05-15 20:30:54 UTC
Patch also successfully allows dvdbackup to compile against media-libs/libdvdread-6.1.1.
Comment 7 Alexis Ballier gentoo-dev 2020-05-18 16:30:39 UTC
*** Bug 722004 has been marked as a duplicate of this bug. ***
Comment 8 Larry the Git Cow gentoo-dev 2020-05-18 16:35:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e92c80f3bf681e9a92b15faf3ff194848d01b05c

commit e92c80f3bf681e9a92b15faf3ff194848d01b05c
Author:     Alexis Ballier <aballier@gentoo.org>
AuthorDate: 2020-05-18 16:34:26 +0000
Commit:     Alexis Ballier <aballier@gentoo.org>
CommitDate: 2020-05-18 16:35:04 +0000

    media-video/dvdbackup: fix build with latest libdvdread
    
    Patch from freebsd/ubuntu provided to us by  Christohper Harrington
    
    Closes: https://bugs.gentoo.org/721732
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Alexis Ballier <aballier@gentoo.org>

 media-video/dvdbackup/dvdbackup-0.4.2.ebuild      |  1 +
 media-video/dvdbackup/files/libdvdread-6.1.0.diff | 92 +++++++++++++++++++++++
 2 files changed, 93 insertions(+)
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-10-15 10:02:48 UTC
*** Bug 748599 has been marked as a duplicate of this bug. ***