Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 720678 - sys-apps/texinfo-6.7: use BDEPEND with EAPI 7
Summary: sys-apps/texinfo-6.7: use BDEPEND with EAPI 7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-02 16:35 UTC by David Michael
Modified: 2020-06-09 18:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Attach the inline patch (texinfo-6.7.patch,676 bytes, patch)
2020-05-02 16:50 UTC, David Michael
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2020-05-02 16:35:58 UTC
The 6.7 ebuild uses EAPI 7 without defining BDEPEND.  That causes it to install ROOT=/ dependencies in the sysroot unnecessarily.  In this case, Perl and gettext seem to only be used from / (but Perl is also a runtime dependency for the installed scripts).

Reproducible: Always




I tried building the following change in a sysroot which seems to work.  This dropped old blockers and minimum versions that have been removed from the tree so it looks cleaner and consistent with other packages' BDEPENDs.  It also dropped xz-utils since I didn't see where it's used, and it's in the base package set anyway.

--- sys-apps/texinfo/texinfo-6.7.ebuild
+++ sys-apps/texinfo/texinfo-6.7.ebuild
@@ -19,8 +19,6 @@
 IUSE="nls +standalone static"
 
 RDEPEND="
-	!=app-text/tetex-2*
-	>=sys-libs/ncurses-5.2-r2:0=
 	standalone? ( dev-lang/perl )
 	!standalone?  (
 		dev-lang/perl:=
@@ -28,10 +26,14 @@
 		dev-perl/Unicode-EastAsianWidth
 		dev-perl/Text-Unidecode
 	)
+"
+BDEPEND="${RDEPEND}
+	nls? ( sys-devel/gettext )"
+DEPEND="
+	sys-libs/ncurses:0=
 	nls? ( virtual/libintl )"
-DEPEND="${RDEPEND}
-	app-arch/xz-utils
-	nls? ( >=sys-devel/gettext-0.19.6 )"
+RDEPEND="${RDEPEND}
+	${DEPEND}"
 
 src_configure() {
 	# Respect compiler and CPPFLAGS/CFLAGS/LDFLAGS for Perl extensions. #622576
Comment 1 David Michael 2020-05-02 16:50:16 UTC
Created attachment 635716 [details, diff]
Attach the inline patch
Comment 2 Larry the Git Cow gentoo-dev 2020-06-09 18:47:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b676a05f11cb197cd636d4ac5a290d3bc656479

commit 6b676a05f11cb197cd636d4ac5a290d3bc656479
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-06-09 18:47:15 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-06-09 18:47:46 +0000

    sys-apps/texinfo: fix deps
    
    Closes: https://bugs.gentoo.org/720678
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-apps/texinfo/texinfo-6.7.ebuild | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)