SRC_URI mirror://sourceforge/${PN}/pg-data.tar.gz includes the following README ----------8<------------------------- Panzer General Data (DOS Version) The contents of this package is copyrighted by SSI which is now part of UBI Soft. I did not receive an answer for a request on whether I may use the Panzer General data for LGeneral, which is a non-commercial product. I assume that no response means, that they don't care about it. As UBI Soft does not sell this game any longer and as I do not earn any money with LGeneral, I have made some of the PG resources available for download in the spirit of abandonware and to keep a great game alive. However, if you still sell Panzer General (DOS Version) and think that financial damage is done to you or if you hold the copyright for this game and do not want me to publish some of its data, please contact me immediately: http://lgames.sf.net/contact.php You have to use LGC-PG (included to the LGeneral package) to convert the data. For example, if you have installed LGeneral to the default path /usr/local/share/games/lgeneral and extracted this data package to ~/tmp/pg-data, then run (as ROOT) lgc-pg -s ~/tmp/pg-data -d /usr/local/share/games/lgeneral For more information on the converter please see README.lgc-pg from the source package. Feedback or suggestions? Visit http://lgames.sf.net/contact.php ----------8<-------------------------
The information from that README basically says that this package cannot be redistributed, and that upstream is distributing it without having the right to do so. I guess that means that we must remove this package.
It does say you can provide the data yourself. I was half way to asking whether there's any point but it's not *that* long since this saw a new release and Soap only bumped it in January. I could give it a look. I think upstream's stance is reasonable even though it's not acceptable for us. The stupid part is that, if the screenshots are anything to go by, you could probably get much better permissively licensed images for free or for a small fee.
Sure, just removing pg-data.tar.gz would be fine. Maybe add a README.gentoo with instructions that users who own a legal copy of the game can install these assets themselves?
removing pg-data.tar.gz is what ubuntu/mint did. It is fine then, but you have a broken entry for WWII Scenario in the game menu. I think we can solve this with an einfo if no one has objections.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a57c787dc3d0222359db99aa6ba8825a8eff30e8 commit a57c787dc3d0222359db99aa6ba8825a8eff30e8 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2021-08-09 03:19:12 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2021-08-09 04:50:07 +0000 games-strategy/lgeneral: add 1.4.4, various fixes Notable ebuild changes: * Add free kukgen WWI campaign * Remove non-free original Panzer General WW2 campaign wrt bug #720306 * Remove @GENTOO@ seds that have been doing nothing for over 10 years, and also the double build that should now allow for working cross-compilation (extra build not needed wihout above pg-data) * Remove duplicate .desktop (keep upstream's) This version also happen to fix musl issues wrt bug #712346 Closes: https://bugs.gentoo.org/712346 Closes: https://bugs.gentoo.org/720306 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> games-strategy/lgeneral/Manifest | 2 + games-strategy/lgeneral/lgeneral-1.4.4.ebuild | 66 +++++++++++++++++++++++++++ 2 files changed, 68 insertions(+)
