Bug 720054 – dev-libs/icu-67.1 breaks dev-qt/qtwebengine-5.15.0-beta4 USE=system-icu [qt overlay] (likely plus 5.14.x::gentoo) error: 'class icu::number::FormattedNumber' has no member named 'getAllFieldPositions';

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Duncan 2020-04-30 02:51:59 UTC]

Created attachment 635256 [details]
emerge --info qtwebengine

It seems icu-67 removes icu::number::FormattedNumber::getAllFieldPositions().    See the APIChangedReport.(html|md) files in the icu-67.1 sources.  (The tables are a bit hard to read, appearing to say it's removed in icu-66, but AFAICT based on the error against 67 but not 66 and the same file in 66's sources, it's actually saying 66 still had the never-stabilized draft from 62, but it's "missing" in 67.)

That results in the following error trying to build qtwebengine-5.15.0-beta4 USE=system-icu from ::qt, and presumably also 5.14.(1|2) from ::gentoo, as at least 5.14.2 seems to have a similar hit in the sources and the triggering change is icu-67 not qtwebengine.

../../../../qtwebengine-everywhere-src-5.15.0-beta4/src/3rdparty/chromium/v8/src/objects/js-number-format.cc: In function 'v8::Maybe<icu::U
nicodeString> v8::internal::{anonymous}::IcuFormatNumber(v8::internal::Isolate*, const icu::number::LocalizedNumberFormatter&, v8::internal
::Handle<v8::internal::Object>, icu::FieldPositionIterator*)':
../../../../qtwebengine-everywhere-src-5.15.0-beta4/src/3rdparty/chromium/v8/src/objects/js-number-format.cc:1227:15: error: 'class icu::nu
mber::FormattedNumber' has no member named 'getAllFieldPositions'; did you mean 'getAllFieldPositionsImpl'?
1227 |     formatted.getAllFieldPositions(*fp_iter, status);
|               ^~~~~~~~~~~~~~~~~~~~
|               getAllFieldPositionsImpl

I just finished rebuilding with USE=-system-icu as confirmation and a workaround, so that does appear to work.

I'm attaching emerge --info and will attach the build log as well.

[Comment 1 Duncan 2020-04-30 03:04:49 UTC]

Created attachment 635258 [details]
failing build log (xz-ed to fit)

[Comment 2 Jouni Kosonen 2020-04-30 04:16:24 UTC]

5.14.2::gentoo already has a patch for that, in commit a2fe6a6c80b5cc.

[Comment 3 Duncan 2020-04-30 07:24:06 UTC]

(In reply to Jouni Kosonen from comment #2)
> 5.14.2::gentoo already has a patch for that, in commit a2fe6a6c80b5cc.

Thanks for the tip!  Missed that but I'll have to try it.

[Comment 4 Larry the Git Cow 2020-04-30 09:26:58 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=b078110093de1ca03bf41d781d4e720eeaf56fd6

commit b078110093de1ca03bf41d781d4e720eeaf56fd6
Author:     Lars Wendler <[e-mail]>
AuthorDate: 2020-04-29 20:38:38 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2020-04-30 09:26:41 +0000

    dev-qt/qtwebengine: Fixed build with icu-67
    
    Closes: https://bugs.gentoo.org/720054
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Lars Wendler <[e-mail]>
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 .../files/qtwebengine-5.14.2-icu67.patch           | 169 +++++++++++++++++++++
 dev-qt/qtwebengine/qtwebengine-5.15.0_beta4.ebuild |   5 +-
 dev-qt/qtwebengine/qtwebengine-5.15.9999.ebuild    |   5 +-
 3 files changed, 177 insertions(+), 2 deletions(-)