Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 719800 - www-client/firefox-75.0-r2 breaks hardware acceleration
Summary: www-client/firefox-75.0-r2 breaks hardware acceleration
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-27 13:13 UTC by Mikael Puhakka
Modified: 2020-05-06 14:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix to firefox to revert problematic behavior with nvidia cards in firefox-75.0-r2 (fix_nvidia_rendering.patch,559 bytes, patch)
2020-04-28 00:45 UTC, anna
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Puhakka 2020-04-27 13:13:18 UTC
(Using nvidia-blob so maybe nobody cares) but after switching from 75.0-r1  to -r2  www-client/ffirefox loses HW acceleration.

Reverting back to 75.0-r1 regains it. Naturally clean profiles were tested.

nvidia-drivers-440.64
4.19.113-gentoo
xorg-x11

Installed versions:  75.0-r2^td(10:10:32 AM 04/27/2020)(gmp-autoupdate hwaccel screenshot system-av1 system-harfbuzz system-icu system-jpeg system-libevent system-webp -bindist -clang -custom-cflags -custom-optimization -debug -eme-free -geckodriver -hardened -jack -lto -pgo -pulseaudio -selinux -startup-notification -system-libvpx -test -wayland -wifi CPU_FLAGS_ARM="-neon" CPU_FLAGS_X86="-avx2" )

Installed versions:  75.0-r1^td(04:10:21 PM 04/27/2020)(gmp-autoupdate hwaccel screenshot system-av1 system-harfbuzz system-icu system-jpeg system-libevent system-webp -bindist -clang -custom-cflags -custom-optimization -debug -eme-free -geckodriver -hardened -jack -lto -pgo -pulseaudio -selinux -startup-notification -system-libvpx -test -wayland -wifi CPU_FLAGS_ARM="-neon" CPU_FLAGS_X86="-avx2" )
Comment 1 Mikael Puhakka 2020-04-27 13:14:35 UTC
Portage 2.3.89 (python 3.6.10-final-0, default/linux/amd64/17.1, gcc-9.2.0, glibc-2.30-r8, 4.19.113-gentoo x86_64)
=================================================================
System uname: Linux-4.19.113-gentoo-x86_64-Intel-R-_Core-TM-_i5-2500K_CPU_@_3.30GHz-with-gentoo-2.6
KiB Mem:    24652496 total,  16629480 free
KiB Swap:    4699132 total,   4698108 free
Timestamp of repository gentoo: Mon, 27 Apr 2020 01:15:01 +0000
Head commit of repository gentoo: 512c60d6f092070e2fab9dfed8fa28a9e05dc591
sh bash 5.0_p17
ld GNU ld (Gentoo 2.33.1 p2) 2.33.1
ccache version 3.7.7 [enabled]
app-shells/bash:          5.0_p17::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.1::gentoo
dev-lang/python:          2.7.18::gentoo, 3.5.7::gentoo, 3.6.10-r2::gentoo, 3.7.7-r2::gentoo, 3.8.2-r2::gentoo
dev-util/ccache:          3.7.7-r1::gentoo
dev-util/cmake:           3.16.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.14.1-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.2.0-r2::gentoo, 9.3.0::gentoo
sys-devel/gcc-config:     2.2.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30-r8::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.europe.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

bitcoin
    location: /var/lib/layman/bitcoin
    masters: gentoo
    priority: 50

haskell
    location: /var/lib/layman/haskell
    masters: gentoo
    priority: 50

java
    location: /var/lib/layman/java
    masters: gentoo
    priority: 50

sft
    location: /var/lib/layman/sft
    masters: gentoo
    priority: 50

steam-overlay
    location: /var/lib/layman/steam-overlay
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -g -mstackrealign"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O2 -pipe -g -mstackrealign"
DISTDIR="/stor/david/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going --quiet-build=n"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news nostrip parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="ftp://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/  ftp://ftp.fi.muni.cz/pub/linux/gentoo/ "
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en_US en_GB en fi"
MAKEOPTS="-j7"
PKGDIR="/usr/portage/packages"
PORTAGE_BINHOST="http://packages.gentooexperimental.org/"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X acl alsa amd64 avx bash-completion berkdb bluray bzip2 cli crypt dri fbcondecor fortran gdbm gif iconv ipv6 jpeg libtirpc mmx mp3 multilib ncurses nls nptl offensive ogg openmp pam pcre png readline seccomp split-usr sse sse2 ssl ssse3 svg tcpd tiff unicode vim vim-syntax xattr xft xinerama zlib zsh-completion" ABI_X86="64 32" ADA_TARGET="gnat_2018" ALSA_CARDS="ice1724 ice1712" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" L10N="en-US en-GB en fi" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2020-04-27 15:29:57 UTC
How do you test? Why are you assuming you lost HW acceleration?

-r2 was only bumped to move away from virtual/ffmpeg to media-video/ffmpeg and https://hg.mozilla.org/releases/mozilla-beta/rev/1895138266c3 was added (but because you don't use Wayland, you shouldn't be affected).
Comment 3 Mikael Puhakka 2020-04-27 15:54:23 UTC
(In reply to Thomas Deutschmann from comment #2)
> How do you test? Why are you assuming you lost HW acceleration?

Telltale symptoms in my system:

(1) Overall sluggishness on render-heavy pages; 
(2) increased CPU usage;
(3) autoscroll icon suddenly stopped glitching (*);
(4) pages while scrolling and video started to tear, losing vsync.


(*) I may have to explain this one for a bit! When one autoscrolls with the mouse by clicking the middle button, there's a special icon that shows what's happening. In my case this icon's mask doesn't get applied in HW-accelerated mode, resulting in an ugly square black-backgrounded white icon. This behavior is old (back when Firefox allowed user to disable hardware acceleration in the settings I could make note of what caused the glitch by switching between modes) and I have grown accustomed to it.

I actually first noticed something might be wrong when this icon rendered with mask properly applied.

The autoscroll icon in Windows: https://www.howtogeek.com/wp-content/uploads/2008/03/image136.png

Anyway, I digress.


I read the changelog on -r2 too and yes, seems somewhat bizarre behavior on such a small and innocent patch. 

I'm fine using 75.0-r1 and will build and test whatever comes next, after 75.0-r2. I just wanted to document my findings in case there are more affected.
Comment 4 alpir 2020-04-27 16:06:57 UTC
Look at this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1631353
Comment 5 Mikael Puhakka 2020-04-27 16:38:01 UTC
(In reply to alpir from comment #4)
> Look at this bug:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1631353

I wouldn't like to dismiss anything without giving it a proper testing but I don't quite think this matches my experience. 

I've been using firefox 73 since February, firefox 74 since March, and firefox 75 since April 7th. No issues with perceived slowdowns with any of the versions until 75.0-r2. On the side I use Vivaldi when I'm web-developing. The same pages render equally fast on both platforms (gut benchmark, the synthetic ones surely give a considerate difference in numbers).

Add in the missing vsync, causing tear (which I notice immediately, it being fatal for consuming video in my opinion) and the other symptoms I'm inclined to think the HW acceleration is not running slow, it is plain missing.
Comment 6 anna 2020-04-27 23:44:32 UTC
I am encountering this as well, I have an nvidia graphics card and if I play a youtube video while playing FFXIV, FFXIV becomes headache-inducingly choppy and unplayable

This really stinks because I very much enjoy doing both of these things at the same time!
Comment 7 anna 2020-04-28 00:45:15 UTC
Created attachment 634956 [details, diff]
Fix to firefox to revert problematic behavior with nvidia cards in firefox-75.0-r2
Comment 8 anna 2020-04-28 00:51:13 UTC
Above I have attached a patch I made out of the linked bug thread. Since this process is relatively new to me, for anyone else who doesn't quite know how to apply patches in portage offhand:

1) copy patch file to /etc/portage/patches/www-client/firefox-75.0-r2/

2) make sure it works by doing the following, adapted from the gentoo wiki page on patches:

$ cd $(portageq get_repo_path / gentoo)/www-client/firefox
$ sudo ebuild firefox-75.0-r2.ebuild clean prepare

3) emerge firefox again using the --oneshot option to force a recompile

Hopefully these instructions help someone, will report back if this patch actually works
Comment 9 anna 2020-04-28 01:00:06 UTC
Unfortunately after all that... this did not fix the issue for me
Comment 10 hajit 2020-04-28 05:02:09 UTC
maybe that firefox-75.0-patches-6 missing 0001-Install-the-Gentoo-preference-file-into-the-omni.jar.patch related
Comment 11 Larry the Git Cow gentoo-dev 2020-04-28 20:08:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a3c3a0ff441656bb68914e11b51efdace95590c6

commit a3c3a0ff441656bb68914e11b51efdace95590c6
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-04-28 20:06:40 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-04-28 20:08:40 +0000

    www-client/firefox: fix patch set
    
    Closes: https://bugs.gentoo.org/719952
    Bug: https://bugs.gentoo.org/719800
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/Manifest                                           | 2 +-
 www-client/firefox/{firefox-75.0-r2.ebuild => firefox-75.0-r3.ebuild} | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 12 Thomas Deutschmann (RETIRED) gentoo-dev 2020-04-28 20:12:40 UTC
When I updated patch set I used `git cherry-pick <sha1-first-patch>...<sha1-last-patch>` but looks like this command will pick patches *after* sha1-first-patch so an important patch was missing causing firefox to lack our preferences. Sorry about that.

I'll leave this open until first -r3 user will report that the performance issues are now resolved.
Comment 13 gwaftdsk 2020-04-29 06:52:08 UTC
I was using software rendering before, but hardware acceleration enabled itself in firefox-75.0.r3. I think layers.acceleration.force-enabled changed itself to true.

The bookmarks menu isn't highlighting properly with hardware acceleration. Since I was using software, I don't know if that's new in r3.
Comment 14 Mikael Puhakka 2020-04-29 07:27:10 UTC
I built -r3 and this fixed the issue for me. Many thanks!