It looks like gajim used to do something with NetworkManager, based on fuzzy outdated translation strings, but nothing anymore in currently in tree versions (can only find said fuzzy strings). In Gentoo we however still have a USE=networkmanager and NM dep then. Please confirm and remove the unnecessary dep if that's true.
Looks like you're right. Now I wonder: Technically we should bump for a dependency change. Though that would delay the stabilization request you also filed. (Or we stabilize with the wrong dep, which would also be unfortunate.) How should we proceed best?
On the other hand I also wanted to move forward with supporting python 3.8. And that would require a bit of dependency stabilization. So let's go with stabilizing what we have, bump with the fixed dependency and python 3.8 and then move forward.
If we are 100% sure that the dep isn't needed, I don't think it's a problem just removing it without revbump and still going forward with stabilization. ~arch users will get rid of the dep in VDB from --changed-use too, but it's not important at all for them to do so - it's not used, afterall, and they didn't mind the dep before (they had USE=networkmanager enabled)
Anyhow, it's fine either way, can do it later too if you want. It's just something I noticed while reviewing networkmanager consumers for any hidden libnm-glib/libnm-util usages (which go away after 1.18) and made sure to get it reported :)
I'm not 100% sure, I'd rather let it go for a round of testing and stabilize what we have now. the 1.1.3-r1 ebuild is better than the old 1.0, and that also has the unnecessary dep, so we get to stabilize something better either way.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4141d2ed6f56c92a6f602d19ae52c0696d4d6d95 commit 4141d2ed6f56c92a6f602d19ae52c0696d4d6d95 Author: Hanno Böck <hanno@gentoo.org> AuthorDate: 2020-04-26 17:18:37 +0000 Commit: Hanno Böck <hanno@gentoo.org> CommitDate: 2020-04-26 17:18:37 +0000 net-im/gajim: Python 3.8 support and cleanup. Remove networkmanager dependency (#719560). Replace obsolete PYTHON_MULTI_USEDEP. Don't restrict test. Update URL. Closes: https://bugs.gentoo.org/719560 Signed-off-by: Hanno Böck <hanno@gentoo.org> Package-Manager: Portage-2.3.99, Repoman-2.3.22 net-im/gajim/gajim-1.1.3-r2.ebuild | 83 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+)
