Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 719208 - app-arch/rpm2targz-9.0.0.5g fails to handle some of more recent rpms
Summary: app-arch/rpm2targz-9.0.0.5g fails to handle some of more recent rpms
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL: https://gitweb.gentoo.org/proj/rpm2ta...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-24 09:48 UTC by Rafał Mużyło
Modified: 2021-03-16 23:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch fixing described problem (rpmoffset-add-zstd.patch,727 bytes, patch)
2020-04-24 09:48 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2020-04-24 09:48:36 UTC
Created attachment 634352 [details, diff]
patch fixing described problem

Quite awhile ago, an additional compression format was added to rpm.
https://github.com/rpm-software-management/rpm/commit/3684424fe297c996bb05bb64631336fa2903df12

rpm2targz has yet to update.

So, attached patch seems to fix the problem (as long as zstd is installed, but that's the same as for other compression methods).
Comment 1 Larry the Git Cow gentoo-dev 2020-04-24 11:55:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7660d41c70d1c01a0bbd06ecbaad3be2a8968d4

commit e7660d41c70d1c01a0bbd06ecbaad3be2a8968d4
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-04-24 11:55:03 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-04-24 11:55:14 +0000

    app-arch/rpm2targz: add zstd support
    
    Closes: https://bugs.gentoo.org/719208
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 .../rpm2targz-9.0.0.5g-add-zstd-support.patch      | 20 +++++++++++++++
 app-arch/rpm2targz/rpm2targz-9.0.0.5g-r2.ebuild    | 30 ++++++++++++++++++++++
 2 files changed, 50 insertions(+)
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2020-04-24 11:57:46 UTC
Thank you for the patch.

I added a mandatory RDEPEND on app-arch/zstd given that new rpms from Fedora and others are now using zstd by default.
Comment 3 Benda Xu gentoo-dev 2020-04-26 12:47:52 UTC
Thomas, the -r2 has broken Prefix with the following modifications in src_install().

--- rpm2targz-9.0.0.5g-r1.ebuild	2020-04-11 20:52:33.047209841 +0800
+++ rpm2targz-9.0.0.5g-r2.ebuild	2020-04-26 20:44:10.343931564 +0800
@@ -23,5 +26,5 @@
 
 src_install() {
-	emake DESTDIR="${ED}" install # need explicit install line #397835
+	emake DESTDIR="${D}" install # need explicit install line #397835
 	dodoc *.README*
 }
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2020-04-26 12:56:49 UTC
Sorry, I changed this on purpose because I thought emake is prefix-aware. But this is only true when configure was used before.
Comment 5 Larry the Git Cow gentoo-dev 2020-04-26 12:58:09 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5315de7b2a1639d5282900cf77c6e78a93b417a8

commit 5315de7b2a1639d5282900cf77c6e78a93b417a8
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2020-04-26 12:57:00 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2020-04-26 12:58:00 +0000

    app-arch/rpm2targz: fix Prefix regression by e7660d41.
    
    Closes: https://bugs.gentoo.org/719208
    Package-Manager: Portage-2.3.88, Repoman-2.3.18
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 app-arch/rpm2targz/rpm2targz-9.0.0.5g-r2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Larry the Git Cow gentoo-dev 2020-04-26 13:00:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7219eef8e93337359c2e13ed1727ee67846cb04b

commit 7219eef8e93337359c2e13ed1727ee67846cb04b
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-04-26 12:59:40 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-04-26 12:59:59 +0000

    app-arch/rpm2targz: fix prefix installation
    
    Closes: https://bugs.gentoo.org/719208
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 app-arch/rpm2targz/files/rpm2targz-9.0.0.5g-add-zstd-support.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Benda Xu gentoo-dev 2020-04-26 13:02:00 UTC
(In reply to Thomas Deutschmann from comment #4)
> Sorry, I changed this on purpose because I thought emake is prefix-aware.
> But this is only true when configure was used before.

No problem.  I have committed a trivial fix.  And oops, it looks like we have stepped on each other's toes.  Sorry.
Comment 8 SpanKY gentoo-dev 2021-03-16 23:35:37 UTC
merged to the rpm2targz project itself:
https://gitweb.gentoo.org/proj/rpm2targz.git/commit/?id=9abf939441a6d38c512f8723d1c4e62a1f2af611