Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 718636 - dev-python/doit{,-py}: need py3.7, 3.8 port
Summary: dev-python/doit{,-py}: need py3.7, 3.8 port
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Joonas Niilola
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: python3.8-compat 718540
  Show dependency tree
 
Reported: 2020-04-20 15:51 UTC by Michał Górny
Modified: 2020-07-09 08:14 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-20 15:51:22 UTC
The packages are stuck on py3.6 which means they will be pain once we switch to 3.7.  Please test them on 3.7 *and* 3.8 (so we don't to revisit this in a few months), and update PYTHON_COMPAT appropriately.  If it doesn't work, please either fix it, remove Python or issue last rites.  Please consider this urgent.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-20 15:57:26 UTC
@sping, you've touched 'doit' last.  Would you like to maintain it?
Comment 2 Larry the Git Cow gentoo-dev 2020-04-20 16:21:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bf479502d643be430d4e7fbffdaa33da893a75cc

commit bf479502d643be430d4e7fbffdaa33da893a75cc
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2020-04-20 16:20:30 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2020-04-20 16:21:11 +0000

    dev-python/configclass: EAPI 7 + py3[78]
    
    Bug: https://bugs.gentoo.org/718636
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-2.3.99, Repoman-2.3.22

 dev-python/configclass/configclass-0.1.0-r1.ebuild | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 3 Sebastian Pipping gentoo-dev 2020-04-20 16:27:00 UTC
I touched doit in context of bumping www-apps/nikola.  I don't use doit myself.  I may help but I'm not interested in becoming its maintainer.  Afair there was some obstacle to supporting 3.7 and/or 3.8, at least 3.8 seems trouble https://github.com/pydoit/doit/pull/340 .  It also needs py3[78] from dev-python/configclass and dev-python/doit-py.

It seem we touched python/configclass at about the same time now.
I would expect a revbump for adding 3.7 and 3.8 support.
I propose we copy your changes (adding tests and adjusting SRC_URI) to my -r1, revert -r0 back to stable and keep -r1 all testing.  Agree?  Should I make the change?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-20 16:32:21 UTC
(In reply to Sebastian Pipping from comment #3)
> I would expect a revbump for adding 3.7 and 3.8 support.

Don't create useless busywork for arch teams, especially that 3.8 is still masked on stable profiles.
Comment 5 Azamat H. Hackimov 2020-04-22 12:45:31 UTC
Hello.

I would like to take maintainership over these packages since they needed for my projects.

PR for adding python3_7 and major rewrite: https://github.com/gentoo/gentoo/pull/15468
Comment 6 Larry the Git Cow gentoo-dev 2020-05-16 12:59:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a810f99517faa40ef23a0f12769f69585b5bf57

commit 2a810f99517faa40ef23a0f12769f69585b5bf57
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-04-22 12:36:29 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-05-16 12:59:44 +0000

    dev-python/doit: update ebuild
    
    Added python3_7, migrateded to distutils_enable_tests and
    distutils_enable_sphinx. Added bash and zsh autocompletion.
    
    Closes: https://bugs.gentoo.org/718636
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/15468
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-python/doit/doit-0.32.0-r1.ebuild              | 53 ++++++++++++++
 dev-python/doit/files/doit-0.32.0_pytest5.4.patch  | 81 ++++++++++++++++++++++
 dev-python/doit/files/doit-0.32.0_unpickable.patch | 39 +++++++++++
 dev-python/doit/metadata.xml                       | 11 ++-
 4 files changed, 182 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=84a05cae594ef12b78257f5bafd4d3b5724a7ed6

commit 84a05cae594ef12b78257f5bafd4d3b5724a7ed6
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-04-22 11:28:55 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-05-16 12:59:40 +0000

    dev-python/doit-py: add python3_7 to PYTHON_COMPAT
    
    Rewrite doc and test phases to use distutils_enable_sphinx and
    distutils_enable_tests.
    
    Closes: https://bugs.gentoo.org/718636
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-python/doit-py/doit-py-0.4.0-r2.ebuild | 27 +++++++++++++++++++++++++++
 dev-python/doit-py/metadata.xml            | 16 ++++++++++++----
 2 files changed, 39 insertions(+), 4 deletions(-)
Comment 7 Sebastian Pipping gentoo-dev 2020-05-16 14:38:49 UTC
Joonas, thanks for adding Python 3.7.  The ticket title asks for both 3.7 and 3.8 though and 3.8 is still missing:

  # fgrep COMPAT *.ebuild
  doit-0.29.0.ebuild:PYTHON_COMPAT=( python3_6 )
  doit-0.32.0.ebuild:PYTHON_COMPAT=( python3_6 )
  doit-0.32.0-r1.ebuild:PYTHON_COMPAT=( python3_{6,7} )

  # fgrep COMPAT *.ebuild
  doit-py-0.4.0.ebuild:PYTHON_COMPAT=( python3_6 )
  doit-py-0.4.0-r1.ebuild:PYTHON_COMPAT=( python3_6 )
  doit-py-0.4.0-r2.ebuild:PYTHON_COMPAT=( python3_{6,7} )

So I'm re-opening the ticket for 3.8.  Please let me know if I'm missing something.
Comment 8 Andreas Sturmlechner gentoo-dev 2020-05-23 14:12:21 UTC
Hm, unfortunately the dependency on >=pytest-5.4 means it blocks stabilisation of the first py37 compatible version...
Comment 9 Larry the Git Cow gentoo-dev 2020-07-09 08:13:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c313d784e21b3349f3203dc08e57bb510505e185

commit c313d784e21b3349f3203dc08e57bb510505e185
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-07-07 14:02:13 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-07-09 08:13:10 +0000

    dev-python/doit: add python3_8 target
    
    Bug: https://bugs.gentoo.org/718636
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16626
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-python/doit/doit-0.32.0-r2.ebuild | 54 +++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af8e3fb133e0a8ad2497631145be3d61bb9823a3

commit af8e3fb133e0a8ad2497631145be3d61bb9823a3
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-07-07 14:00:20 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-07-09 08:13:09 +0000

    dev-python/doit-py: update to 0.5.0
    
    Added python3_8 target.
    
    Bug: https://bugs.gentoo.org/718636
    Package-Manager: Portage-2.3.99, Repoman-2.3.23
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-python/doit-py/Manifest             |  1 +
 dev-python/doit-py/doit-py-0.5.0.ebuild | 26 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+)