Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 718556 - net-misc/spice-gtk-0.38: missing dependency on pyparsing
Summary: net-misc/spice-gtk-0.38: missing dependency on pyparsing
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-20 06:16 UTC by Patrick Lauer
Modified: 2020-12-30 15:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2020-04-20 06:16:25 UTC
|Message: Checking for python module six
|Message: Checking for python module pyparsing

subprojects/spice-common/meson.build:131:6: ERROR: Problem encountered: Python module pyparsing not found

A full log can be found at /home/vartmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38-build/meson-logs/meson-log.txt
 * ERROR: net-misc/spice-gtk-0.38::gentoo failed (configure phase):
 *   (no error message)


*  dev-python/pyparsing
      Latest version available: 2.4.7
      Latest version installed: [ Not Installed ]
      Size of files: 633 KiB
      Homepage:      https://github.com/pyparsing/pyparsing https://pypi.org/project/pyparsing/
      Description:   Easy-to-use Python module for text parsing
      License:       MIT


Portage 2.3.99 (python 3.6.10-final-0, default/linux/amd64/17.0, gcc-9.3.0, glibc-2.30-r8, 5.6.2-gentoo x86_64)
=================================================================
System uname: Linux-5.6.2-gentoo-x86_64-Intel-R-_Core-TM-_i7-7600U_CPU_@_2.80GHz-with-gentoo-2.7
KiB Mem:    16205156 total,   7292652 free
KiB Swap:          0 total,         0 free
sh bash 5.0_p16
ld GNU ld (Gentoo 2.34 p1) 2.34.0
app-shells/bash:          5.0_p16::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.2::gentoo
dev-lang/python:          2.7.17-r2::gentoo, 3.6.10-r1::gentoo, 3.7.7-r1::gentoo, 3.8.2-r1::gentoo
dev-util/cmake:           3.17.1::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2::gentoo
sys-devel/binutils:       2.34::gentoo
sys-devel/gcc:            9.3.0::gentoo
sys-devel/gcc-config:     2.2.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.6::gentoo (virtual/os-headers)
sys-libs/glibc:           2.30-r8::gentoo
Repositories:

gentoo
    location: /home/me/code/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts:
    sync-rsync-verify-metamanifest: no
    sync-rsync-verify-jobs: 1

adjust
    location: /home/me/code/adjust/gentoo-overlay
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native"
DISTDIR="/home/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="/etc/X11/xinit/xinitrc.d/80-dbus /usr/bin/dbus-launch"
LANG="C.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j4"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/home/vartmp"
USE="X acl amd64 berkdb bzip2 cli crypt dri fortran gdbm glamor gmp iconv icu idn infinality ipv6 jpeg libtirpc lto mp3 multilib ncurses nls nptl opengl openmp pam pcre png readline seccomp split-usr sqlite ssl tcpd theora tiff tk unicode vaapi vdpau x264 xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="fbdev intel vesa i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 mz.inboxme 2020-04-25 08:35:50 UTC
Build log:

>>> Emerging (28 of 28) net-misc/spice-gtk-0.38::gentoo
 * spice-gtk-0.38.tar.xz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                                                                       [ ok ]
>>> Unpacking source...
>>> Unpacking spice-gtk-0.38.tar.xz to /var/tmp/portage/net-misc/spice-gtk-0.38/work
>>> Source unpacked in /var/tmp/portage/net-misc/spice-gtk-0.38/work
>>> Preparing source in /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38 ...
meson setup --buildtype plain --libdir lib64 --localstatedir /var/lib --prefix /usr --sysconfdir /etc --wrap-mode nodownload --pkg-config-path=/usr/lib64/pkgconfig -Dgtk=enabled -Dintrospection=enabled -Dbuiltin-mjpeg=false -Dpolkit=enabled -Dpulse=disabled -Dlz4=enabled -Dsasl=disabled -Dsmartcard=disabled -Dusbredir=enabled -Dvapi=disabled -Dwebdav=disabled -D usb-acl-helper-dir=/usr/libexec -D usb-ids-path=/usr/share/misc/usb.ids /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38 /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38-build
The Meson build system
Version: 0.54.0
Source dir: /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38
Build dir: /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38-build
Build type: native build
Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
Project name: spice-gtk
Project version: 0.38
Using 'CC' from environment with value: 'x86_64-pc-linux-gnu-gcc'
Using 'CFLAGS' from environment with value: '-march=ivybridge -O2 -pipe'
Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
Using 'CPPFLAGS' from environment with value: ''
Using 'AR' from environment with value: 'x86_64-pc-linux-gnu-ar'
Using 'CC' from environment with value: 'x86_64-pc-linux-gnu-gcc'
Using 'CFLAGS' from environment with value: '-march=ivybridge -O2 -pipe'
Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
Using 'CPPFLAGS' from environment with value: ''
C compiler for the host machine: x86_64-pc-linux-gnu-gcc (gcc 9.3.0 "x86_64-pc-linux-gnu-gcc (Gentoo 9.3.0 p2) 9.3.0")
C linker for the host machine: x86_64-pc-linux-gnu-gcc ld.bfd 2.34
Using 'AR' from environment with value: 'x86_64-pc-linux-gnu-ar'
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program build-aux/meson-dist found: YES (/var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38/build-aux/meson-dist)

|Executing subproject spice-common method meson 
|
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Project name: spice-common
|Project version: undefined
|C compiler for the host machine: x86_64-pc-linux-gnu-gcc (gcc 9.3.0 "x86_64-pc-linux-gnu-gcc (Gentoo 9.3.0 p2) 9.3.0")
|C linker for the host machine: x86_64-pc-linux-gnu-gcc ld.bfd 2.34
|Has header "alloca.h" : YES 
|Has header "arpa/inet.h" : YES 
|Has header "dlfcn.h" : YES 
|Has header "inttypes.h" : YES 
|Has header "netinet/in.h" : YES 
|Has header "stdlib.h" : YES 
|Has header "sys/socket.h" : YES 
|Has header "sys/stat.h" : YES 
|Has header "sys/types.h" : YES 
|Has header "unistd.h" : YES 
|Has header "regex.h" : YES 
|Has header "sys/mman.h" : YES 
|Checking for function "alloca" : YES 
|Checking for function "sigaction" : YES 
|Checking for function "drand48" : YES 
|Checking for function "setlinebuf" : YES 
|Library m found: YES
|Using 'PKG_CONFIG' from environment with value: 'x86_64-pc-linux-gnu-pkg-config'
|Found pkg-config: /usr/bin/x86_64-pc-linux-gnu-pkg-config (1.6.3)
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency spice-protocol found: YES 0.14.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency glib-2.0 found: YES 2.64.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency gio-2.0 found: YES 2.64.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency gthread-2.0 found: YES 2.64.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency pixman-1 found: YES 0.40.0
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency openssl found: YES 1.1.1g
|Found CMake: /usr/bin/cmake (3.17.1)
|Using 'CXX' from environment with value: 'x86_64-pc-linux-gnu-g++'
|Using 'CXXFLAGS' from environment with value: '-march=ivybridge -O2 -pipe'
|Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
|Using 'CPPFLAGS' from environment with value: ''
|Using 'FFLAGS' from environment with value: '-O2 -pipe'
|Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
|Run-time dependency celt051 found: NO (tried pkgconfig and cmake)
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency opus found: YES 1.3.1
|Program python3 found: YES (/usr/bin/python3.6)
|Message: Checking for python module six
|Message: Checking for python module pyparsing

>>> Emerging (28 of 28) net-misc/spice-gtk-0.38::gentoo
 * spice-gtk-0.38.tar.xz BLAKE2B SHA512 size ;-) ...                                                                                                                                                                                                                       [ ok ]
>>> Unpacking source...
>>> Unpacking spice-gtk-0.38.tar.xz to /var/tmp/portage/net-misc/spice-gtk-0.38/work
>>> Source unpacked in /var/tmp/portage/net-misc/spice-gtk-0.38/work
>>> Preparing source in /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38 ...
meson setup --buildtype plain --libdir lib64 --localstatedir /var/lib --prefix /usr --sysconfdir /etc --wrap-mode nodownload --pkg-config-path=/usr/lib64/pkgconfig -Dgtk=enabled -Dintrospection=enabled -Dbuiltin-mjpeg=false -Dpolkit=enabled -Dpulse=disabled -Dlz4=enabled -Dsasl=disabled -Dsmartcard=disabled -Dusbredir=enabled -Dvapi=disabled -Dwebdav=disabled -D usb-acl-helper-dir=/usr/libexec -D usb-ids-path=/usr/share/misc/usb.ids /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38 /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38-build
The Meson build system
Version: 0.54.0
Source dir: /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38
Build dir: /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38-build
Build type: native build
Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
Project name: spice-gtk
Project version: 0.38
Using 'CC' from environment with value: 'x86_64-pc-linux-gnu-gcc'
Using 'CFLAGS' from environment with value: '-march=ivybridge -O2 -pipe'
Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
Using 'CPPFLAGS' from environment with value: ''
Using 'AR' from environment with value: 'x86_64-pc-linux-gnu-ar'
Using 'CC' from environment with value: 'x86_64-pc-linux-gnu-gcc'
Using 'CFLAGS' from environment with value: '-march=ivybridge -O2 -pipe'
Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
Using 'CPPFLAGS' from environment with value: ''
C compiler for the host machine: x86_64-pc-linux-gnu-gcc (gcc 9.3.0 "x86_64-pc-linux-gnu-gcc (Gentoo 9.3.0 p2) 9.3.0")
C linker for the host machine: x86_64-pc-linux-gnu-gcc ld.bfd 2.34
Using 'AR' from environment with value: 'x86_64-pc-linux-gnu-ar'
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program build-aux/meson-dist found: YES (/var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38/build-aux/meson-dist)

|Executing subproject spice-common method meson 
|
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Project name: spice-common
|Project version: undefined
|C compiler for the host machine: x86_64-pc-linux-gnu-gcc (gcc 9.3.0 "x86_64-pc-linux-gnu-gcc (Gentoo 9.3.0 p2) 9.3.0")
|C linker for the host machine: x86_64-pc-linux-gnu-gcc ld.bfd 2.34
|Has header "alloca.h" : YES 
|Has header "arpa/inet.h" : YES 
|Has header "dlfcn.h" : YES 
|Has header "inttypes.h" : YES 
|Has header "netinet/in.h" : YES 
|Has header "stdlib.h" : YES 
|Has header "sys/socket.h" : YES 
|Has header "sys/stat.h" : YES 
|Has header "sys/types.h" : YES 
|Has header "unistd.h" : YES 
|Has header "regex.h" : YES 
|Has header "sys/mman.h" : YES 
|Checking for function "alloca" : YES 
|Checking for function "sigaction" : YES 
|Checking for function "drand48" : YES 
|Checking for function "setlinebuf" : YES 
|Library m found: YES
|Using 'PKG_CONFIG' from environment with value: 'x86_64-pc-linux-gnu-pkg-config'
|Found pkg-config: /usr/bin/x86_64-pc-linux-gnu-pkg-config (1.6.3)
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency spice-protocol found: YES 0.14.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency glib-2.0 found: YES 2.64.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency gio-2.0 found: YES 2.64.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency gthread-2.0 found: YES 2.64.1
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency pixman-1 found: YES 0.40.0
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency openssl found: YES 1.1.1g
|Found CMake: /usr/bin/cmake (3.17.1)
|Using 'CXX' from environment with value: 'x86_64-pc-linux-gnu-g++'
|Using 'CXXFLAGS' from environment with value: '-march=ivybridge -O2 -pipe'
|Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
|Using 'CPPFLAGS' from environment with value: ''
|Using 'FFLAGS' from environment with value: '-O2 -pipe'
|Using 'LDFLAGS' from environment with value: '-Wl,-O1 -Wl,--as-needed'
|Run-time dependency celt051 found: NO (tried pkgconfig and cmake)
|Using 'PKG_CONFIG_PATH' from environment with value: '/usr/lib64/pkgconfig'
|Run-time dependency opus found: YES 1.3.1
|Program python3 found: YES (/usr/bin/python3.6)
|Message: Checking for python module six
|Message: Checking for python module pyparsing

A full log can be found at /var/tmp/portage/net-misc/spice-gtk-0.38/work/spice-gtk-0.38-build/meson-logs/meson-log.txt
 * ERROR: net-misc/spice-gtk-0.38::gentoo failed (configure phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line  125:  Called src_configure
 *   environment, line 2731:  Called meson_src_configure
 *   environment, line 1951:  Called die
 * The specific snippet of code:
 *       tc-env_build "${mesonargs[@]}" || die

Thanks.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-08-11 09:46:36 UTC
It seems to also be missing a dependency on six.
Comment 3 Larry the Git Cow gentoo-dev 2020-12-30 15:32:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93fd19e645c7bc2484cac4c24bb36e244a13ee01

commit 93fd19e645c7bc2484cac4c24bb36e244a13ee01
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2020-12-30 15:32:13 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2020-12-30 15:32:36 +0000

    net-misc/spice-gtk: handle python deps & remove -Werror
    
    Simple sed to remove Werror for now, it is already removed in upstream
    git so this fix can be removed for next release.
    
    Closes: https://bugs.gentoo.org/744841
    Closes: https://bugs.gentoo.org/718556
    Package-Manager: Portage-3.0.12, Repoman-3.0.2
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 net-misc/spice-gtk/spice-gtk-0.38-r1.ebuild | 126 ++++++++++++++++++++++++++++
 net-misc/spice-gtk/spice-gtk-9999.ebuild    |  16 +++-
 2 files changed, 141 insertions(+), 1 deletion(-)