Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 718120 - www-client/qutebrowser: add python-3.8 support
Summary: www-client/qutebrowser: add python-3.8 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Guillaume Seren
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-19 07:44 UTC by Vasco Gervasi
Modified: 2020-05-12 13:57 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vasco Gervasi 2020-04-19 07:44:36 UTC
Hi,
may I ask to add python-3.8 support to www-client/qutebrowser.
Upstream (https://travis-ci.org/github/qutebrowser/qutebrowser) python 3.8 is tested against.

Thanks


Reproducible: Always
Comment 1 Guillaume Seren 2020-04-19 18:44:00 UTC
Hello,
hum from what I can see on the upstream github,
it should work, but not officially supported.

It is a bit confusing because the readme say:
'Python 3.5.2 or newer (3.6 recommended)'
but the setup.py is:
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',

So maybe ask upstream if they support 3.8 ?
Comment 2 Vasco Gervasi 2020-04-20 16:57:33 UTC
From the github page, I can see that 3.6 is recommended.
But seems that they actively test against 3.5, 3.6, 3.7 and 3.8 on the https://travis-ci.org/github/qutebrowser/qutebrowser.

Also archlinux is shipping qutebrowser against python 3.8.2: https://www.archlinux.org/packages/community/any/qutebrowser/.

Anyway I have created a local qutebrowser-9999 with python 3.8 and is working.
Comment 3 Florian Bruhin 2020-05-11 19:08:00 UTC
Upstream here - that was mainly an oversight, Python 3.8 should be supported without any issues since qutebrowser v1.9.0 (from January).

I adjusted the setup.py and docs accordingly:

https://github.com/qutebrowser/qutebrowser/commit/cbb38c528566560c3f6f1b7d1e83460f23947476
Comment 4 Guillaume Seren 2020-05-11 21:13:46 UTC
Hello Florian :)

Yes I used the setup.py to check python version.

As you say it should be supported since 1.9.0,
I will add it in 1.11.1 witch is actually in review.
Comment 5 Larry the Git Cow gentoo-dev 2020-05-12 13:57:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a74c87075416ecbb5c0c19f3b31e07ec05a60ca2

commit a74c87075416ecbb5c0c19f3b31e07ec05a60ca2
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2020-05-07 20:18:31 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-05-12 13:57:06 +0000

    www-client/qutebrowser: Bump 9999 dependencies
    
    Closes: https://bugs.gentoo.org/721544
    Closes: https://bugs.gentoo.org/718120
    Bug: https://bugs.gentoo.org/721564
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/qutebrowser/qutebrowser-9999.ebuild | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=14002f67cfb94e73bfd80993331e55ef2b6c14b3

commit 14002f67cfb94e73bfd80993331e55ef2b6c14b3
Author:     Guillaume Seren <guillaumeseren@gmail.com>
AuthorDate: 2020-05-07 20:13:40 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-05-12 13:57:06 +0000

    www-client/qutebrowser: Add version bump 1.11.1
    
    Closes: https://bugs.gentoo.org/721544
    Closes: https://bugs.gentoo.org/718120
    Bug: https://bugs.gentoo.org/721564
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Guillaume Seren <guillaumeseren@gmail.com>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 www-client/qutebrowser/Manifest                  |  1 +
 www-client/qutebrowser/qutebrowser-1.11.1.ebuild | 75 ++++++++++++++++++++++++
 2 files changed, 76 insertions(+)