Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 717650 - xfce-base/xfce4-session-4.14.1: Unnecessary REQUIRED_USE="elogind? ( policykit )"?
Summary: xfce-base/xfce4-session-4.14.1: Unnecessary REQUIRED_USE="elogind? ( policyki...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal minor (vote)
Assignee: XFCE Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-16 05:14 UTC by Christopher Head
Modified: 2020-04-17 05:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Head 2020-04-16 05:14:20 UTC
The xfce4-session ebuild has a USE dependency which requires that, if elogind USE flag is enabled, then policykit USE flag must also be enabled. I think that’s actually wrong. The policykit USE flag enables some optional polkit code for doing system shutdown/reboot. As far as I can tell, this code mostly boils down to running “pkexec xfsm-shutdown-helper” as a fallback if other shutdown/reboot mechanisms aren’t available.

When using elogind, that is unnecessary. If elogind is running and makes shutdown/reboot mechanisms available to non-administrative users (most likely via polkit rules), then xfce4-session will talk to elogind via dbus as if it were systemd, and ask elogind to do the shutdown/reboot, and everything will work fine. No pkexec is needed, and XFCE built with USE=-policykit will totally be able to shutdown/reboot the system.

Actually XFCE built with USE=-elogind is perfectly happy to shutdown/reboot the system with elogind running as well, so I’m not totally sure why that USE flag exists, but whether set or clear, it definitely doesn’t need to pull in USE=policykit as well!

Reproducible: Always
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-17 05:51:28 UTC
Yeah, this seems to be correct.  Thanks.
Comment 2 Larry the Git Cow gentoo-dev 2020-04-17 05:54:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=75453c0831c26c2d1e551697686608bb5a135d60

commit 75453c0831c26c2d1e551697686608bb5a135d60
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2020-04-17 05:51:15 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2020-04-17 05:51:55 +0000

    xfce-base/xfce4-session: Remove stale REQUIRED_USE on polkit
    
    Closes: https://bugs.gentoo.org/717650
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 xfce-base/xfce4-session/xfce4-session-4.14.2.ebuild | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)