Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 717320 - net-wireless/broadcom-sta-6.30.223.271-r5 fails to compile with sys-kernel/gentoo-sources-5.6
Summary: net-wireless/broadcom-sta-6.30.223.271-r5 fails to compile with sys-kernel/ge...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal major (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-13 14:01 UTC by Alexander Bartha
Modified: 2020-06-01 22:02 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
broadcom-sta build log (broadcom-sta_build_log.txt,16.54 KB, text/plain)
2020-04-13 14:04 UTC, Alexander Bartha
Details
emerge --info (emerge_info.txt,6.11 KB, text/plain)
2020-04-13 14:24 UTC, Alexander Bartha
Details
Fix (16-linux56.patch,3.05 KB, patch)
2020-04-14 22:11 UTC, hogdog375
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Bartha 2020-04-13 14:01:23 UTC
net-wireless/broadcom-sta-6.30.223.271-r5 fails to compile with >=gentoo-sources-5.6.0

2 patches have offline messages during patching:
broadcom-sta-6.30.223.141-makefile.patch
broadcom-sta-6.30.223.248-r3-Wno-date-time.patch

excerpt:
>>> Preparing source in /var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work ...
 * Applying broadcom-sta-6.30.223.141-makefile.patch ...
patching file Makefile
Hunk #1 succeeded at 147 with fuzz 2 (offset 19 lines).                                                                                                                                                                                                                 [ ok ]
 * Applying broadcom-sta-6.30.223.141-eth-to-wlan.patch ...                                                                                                                                                                                                             [ ok ]
 * Applying broadcom-sta-6.30.223.141-gcc.patch ...                                                                                                                                                                                                                     [ ok ]
 * Applying broadcom-sta-6.30.223.248-r3-Wno-date-time.patch ...
patching file Makefile
Hunk #1 succeeded at 145 with fuzz 2 (offset 19 lines).       

Excerpt from the build log where it fails:

cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:267: /var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work/src/shared/linux_osl.o] Error 1
make[1]: *** Waiting for unfinished jobs....
/var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work/src/wl/sys/wl_linux.c: In function ‘_wl_add_monitor_if’:
/var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work/src/wl/sys/wl_linux.c:2982:2: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
 2982 |  strncpy(wlif->dev->name, wlif->name, strlen(wlif->name));
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:267: /var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work/src/wl/sys/wl_linux.o] Error 1
make: *** [Makefile:1683: /var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work] Error 2
make: Leaving directory '/usr/src/linux-5.6.3-gentoo'
 * ERROR: net-wireless/broadcom-sta-6.30.223.271-r5::gentoo failed (compile phase):
 *   emake failed
 * 
 * If you need support, post the output of `emerge --info '=net-wireless/broadcom-sta-6.30.223.271-r5::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=net-wireless/broadcom-sta-6.30.223.271-r5::gentoo'`.
 * The complete build log is located at '/var/log/portage/net-wireless:broadcom-sta-6.30.223.271-r5:20200413-132523.log'.
 * For convenience, a symlink to the build log is located at '/var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/temp/environment'.
 * Working directory: '/var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work'
 * S: '/var/tmp/portage/portage/net-wireless/broadcom-sta-6.30.223.271-r5/work'

>>> Failed to emerge net-wireless/broadcom-sta-6.30.223.271-r5, Log file:

>>>  '/var/log/portage/net-wireless:broadcom-sta-6.30.223.271-r5:20200413-132523.log'
 


Reproducible: Always
Comment 1 Alexander Bartha 2020-04-13 14:04:38 UTC
Created attachment 632656 [details]
broadcom-sta build log
Comment 2 Alexander Bartha 2020-04-13 14:24:13 UTC
Created attachment 632660 [details]
emerge --info
Comment 3 Jonas Stein gentoo-dev 2020-04-13 18:13:51 UTC
(Why) is this package still required with the recent kernel?
Is there a newer version from broadcom upstream?
Comment 4 hogdog375 2020-04-14 22:11:27 UTC
Created attachment 632982 [details, diff]
Fix

Slightly modified patch made by a user on the debian mailing list.
Comment 5 hogdog375 2020-04-14 22:18:24 UTC
(In reply to Jonas Stein from comment #3)
> (Why) is this package still required with the recent kernel?
> Is there a newer version from broadcom upstream?

Not all devices are supported by that, some still require this driver. My wifi chip (BCM4352) being among them. At least according to https://wiki.gentoo.org/wiki/Wifi#Wireless_supplicant anyway.
Comment 6 Alexander Bartha 2020-04-20 17:46:27 UTC
i also use a BCM4352. 

Thanks for the patch it works perfect and solves the problem.
Comment 7 Alexander Bartha 2020-04-20 17:48:53 UTC
Should i update the status of the ticket?
Comment 8 Larry the Git Cow gentoo-dev 2020-06-01 22:02:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3742de12e9abd41eebaa87c724b49dc39f7d4ce5

commit 3742de12e9abd41eebaa87c724b49dc39f7d4ce5
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-06-01 16:09:39 +0000
Commit:     Stefan Strogin <steils@gentoo.org>
CommitDate: 2020-06-01 22:01:23 +0000

    net-wireless/broadcom-sta: linux 5.6 support
    
    Add patch that resolves compilation error described in #717320.
    
    Closes: https://bugs.gentoo.org/717320
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/16043
    Signed-off-by: Stefan Strogin <steils@gentoo.org>

 .../broadcom-sta-6.30.223.271-r5.ebuild            |  3 +-
 .../broadcom-sta-6.30.223.271-r5-linux-5.6.patch   | 88 ++++++++++++++++++++++
 2 files changed, 90 insertions(+), 1 deletion(-)