Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 717124 - dev-util/bloaty-1.0 version bump
Summary: dev-util/bloaty-1.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-11 17:54 UTC by Michael Jones
Modified: 2020-07-05 08:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Jones 2020-04-11 17:54:23 UTC
Upstream released 1.0 two years ago.

Current version is a year older than that.



Here's a working LIVE ebuild, which solved my immediate problem.

It should be pretty straight forward to update this to work with the official 1.0 release.

# Copyright 1999-2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2

EAPI=6

if [[ ${PV} == "9999" ]] ; then
	inherit cmake-utils git-r3
	EGIT_REPO_URI="https://github.com/google/${PN}.git"
	KEYWORDS="~amd64 ~x86"
else
	inherit cmake-utils
	SRC_URI="https://github.com/google/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"
	KEYWORDS="~amd64 ~x86"
fi

DESCRIPTION="A size profiler for binaries"
HOMEPAGE="https://github.com/google/bloaty"

LICENSE="Apache-2.0"
SLOT="0"
KEYWORDS="~amd64"
IUSE=""

DEPEND=">=dev-libs/re2-0.2017.03.01
	dev-libs/protobuf
	dev-libs/capstone"
RDEPEND="${DEPEND}"

src_prepare() {
	cmake-utils_src_prepare
#	cmake_comment_add_subdirectory third_party/re2
#	cmake_comment_add_subdirectory third_party/capstone
#	cmake_comment_add_subdirectory third_party/protobuf/cmake
}

src_compile() {
	cmake-utils_src_compile
}

src_install() {
	cmake-utils_src_install
}


Reproducible: Always
Comment 1 Jonas Stein gentoo-dev 2020-04-11 19:29:46 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

• Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck
• We always try to use the latest EAPI, please bump to EAPI=7
• Please remove obsolete lines
• please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/)
• A bot can look for additional mistakes, if you upload a PR via github
• The package ships with test functions for google test 
https://github.com/google/bloaty/tree/master/tests
Please add tests to the ebuild.

Join IRC on #gentoo-dev-help, if you get stuck.
Comment 2 Michael Jones 2020-04-11 20:24:57 UTC
@jstein

Thank you very much for the feedback.

Unfortunately, I have had a 1-liner pull request ignored for over a year, and then closed, on the github repository. The 1-liner fixed a package being unable to compile, at all. After my PR was closed, the bug that my 1-line change fixed persisted for at least another 6 months, but perhaps longer.

I have had plenty of other bad experiences with contributions that I've attempted to make to Gentoo, that was just an example.

Due to these bad experiences, I will not be investing any additional time into this, and consider the sample LIVE ebuild that I provided to be "take it or leave it". I needed the package to be updated for an immediate tasks, and got it working. Now that I'm finished with the task that required the updated package, I have no interest in making further improvements to the package.

I can be persuaded to participate more (either with this package, or other things), but before I'm willing to do that, I'll require substantially more effort from Gentoo than "If you file a pull request, it's possible that someone might look at it, or they might not", as has typically been the the feedback that I've received about the subject.
Comment 3 ngg 2020-05-24 13:12:06 UTC
I've created a PR https://github.com/gentoo/gentoo/pull/15944 in which I bumped the version to 1.1, also added a live ebuild and added myself as proxy maintainer.
Comment 4 Larry the Git Cow gentoo-dev 2020-07-05 08:24:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4e7de51a73307c3c473bbc445eabd5b08770d320

commit 4e7de51a73307c3c473bbc445eabd5b08770d320
Author:     Gergely Nagy <ngg@ngg.hu>
AuthorDate: 2020-05-24 10:45:23 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-07-05 08:24:15 +0000

    dev-util/bloaty: bump version to 1.1
    
    Closes: https://bugs.gentoo.org/717124
    Closes: https://bugs.gentoo.org/724160
    Signed-off-by: Gergely Nagy <ngg@ngg.hu>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 dev-util/bloaty/Manifest          |  1 +
 dev-util/bloaty/bloaty-1.1.ebuild | 45 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)