Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 717004 - media-libs/glm-0.9.9.7: missing cmake files cause revdeps to fail to build
Summary: media-libs/glm-0.9.9.7: missing cmake files cause revdeps to fail to build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Tupone Alfredo
URL:
Whiteboard:
Keywords: PullRequest
: 735038 735044 735050 735056 735060 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-11 02:33 UTC by Craig Andrews
Modified: 2020-08-02 01:21 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Andrews gentoo-dev 2020-04-11 02:33:54 UTC
Packages that use cmake to build against glm fail with media-libs/glm-0.9.9.7.

For example, media-plugins/kodi-visualization-goom now fails to build with this output:
---
-- The C compiler identification is GNU 9.3.0
-- The CXX compiler identification is GNU 9.3.0
-- Check for working C compiler: /usr/bin/aarch64-unknown-linux-gnu-gcc
-- Check for working C compiler: /usr/bin/aarch64-unknown-linux-gnu-gcc - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/aarch64-unknown-linux-gnu-g++
-- Check for working CXX compiler: /usr/bin/aarch64-unknown-linux-gnu-g++ - works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Checking to see if CXX compiler accepts flag -flto
-- Checking to see if CXX compiler accepts flag -flto - yes
CMake Error at CMakeLists.txt:7 (find_package):
  By not providing "Findglm.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "glm", but
  CMake did not find one.

  Could not find a package configuration file provided by "glm" with any of
  the following names:

    glmConfig.cmake
    glm-config.cmake

  Add the installation prefix of "glm" to CMAKE_PREFIX_PATH or set "glm_DIR"
  to a directory containing one of the above files.  If "glm" provides a
  separate development package or SDK, be sure it has been installed.
---

The reason is that media-libs/glm-0.9.9.7 is missing these files that media-libs/glm-0.9.9.5 installs:
/usr/lib64/cmake/glm/glmConfig.cmake
/usr/lib64/cmake/glm/glmConfigVersion.cmake
/usr/lib64/cmake/glm/glmTargets.cmake

Looking at upstream, I can see that the current master includes the files:
https://github.com/g-truc/glm/tree/master/cmake/glm
So the solution may be to backport that commit as a patch.

Reproducible: Always

Steps to Reproduce:
1. emerge =media-libs/glm-0.9.9.7
2. emerge media-plugins/kodi-visualization-goom
Comment 1 Craig Andrews gentoo-dev 2020-04-11 02:51:12 UTC
This is the same problem as bug 695648 covered for media-libs/glm-0.9.9.6.
Comment 2 Tupone Alfredo gentoo-dev 2020-04-11 09:36:13 UTC
Upstream does not provide it
However patches are welcome or just fix the ebuild.
Comment 3 Andreas Sturmlechner gentoo-dev 2020-06-04 21:12:20 UTC
(In reply to Craig Andrews from comment #0)
> Looking at upstream, I can see that the current master includes the files:
> https://github.com/g-truc/glm/tree/master/cmake/glm
> So the solution may be to backport that commit as a patch.
Files are there, yes, but upstream *removed* installation of those files, not the other way round:

https://github.com/g-truc/glm/commit/5f352ecce21bb1ab37fa56fac0f383c779b351a3#diff-272ceadb8458515b2ae4b5630a6029cc

Why did they do that is the question?
Comment 4 Andreas Sturmlechner gentoo-dev 2020-06-04 21:13:20 UTC
(In reply to Tupone Alfredo from comment #2)
> Upstream does not provide it
> However patches are welcome or just fix the ebuild.

Aside from raising a bug upstream, you can install those files manually from the ebuild.
Comment 5 Andreas Sturmlechner gentoo-dev 2020-06-04 21:22:59 UTC
(In reply to Craig Andrews from comment #1)
> This is the same problem as bug 695648 covered for media-libs/glm-0.9.9.6.
Can you just patch the source of your package to be able to set GLM_INCLUDE_DIRS via ebuild cmake arg? Assuming that is the only thing it needs.


Even the pkgconfig file is not one shipped by upstream, but it is provided by Gentoo.

Instead it installs /usr/include/glm/CMakeLists.txt which is so wrong.

I don't envy any downstream maintainer of that package.
Comment 6 Andreas Sturmlechner gentoo-dev 2020-06-04 21:54:56 UTC
Revdeps ship their own FindGLM.cmake modules, I just stumbled over one by chance:

https://github.com/naelstrof/slop/blob/master/modules/FindGLM.cmake
Comment 7 Karlson2k 2020-07-29 12:19:28 UTC
Fix for media-libs/glm-0.9.9.8: https://github.com/gentoo/gentoo/pull/16896
Comment 8 Larry the Git Cow gentoo-dev 2020-08-01 14:59:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b13b2f98879179773c114256350c5a2d21f4c15d

commit b13b2f98879179773c114256350c5a2d21f4c15d
Author:     Karlson2k (Evgeny Grin) <k2k@narod.ru>
AuthorDate: 2020-07-29 12:12:50 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2020-08-01 14:59:15 +0000

    media-libs/glm-0.9.9.8: fixes Fixed installation of provided CMake configuration module Skipped build when `test` is not used (header-only library)
    
    Bug: https://bugs.gentoo.org/714778
    Closes: https://bugs.gentoo.org/717004
    
    Signed-off-by: Karlson2k (Evgeny Grin) <k2k@narod.ru>
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 media-libs/glm/glm-0.9.9.8-r1.ebuild | 59 ++++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
Comment 9 Craig Andrews gentoo-dev 2020-08-02 01:15:23 UTC
*** Bug 735044 has been marked as a duplicate of this bug. ***
Comment 10 Craig Andrews gentoo-dev 2020-08-02 01:15:24 UTC
*** Bug 735038 has been marked as a duplicate of this bug. ***
Comment 11 Craig Andrews gentoo-dev 2020-08-02 01:21:02 UTC
*** Bug 735050 has been marked as a duplicate of this bug. ***
Comment 12 Craig Andrews gentoo-dev 2020-08-02 01:21:31 UTC
*** Bug 735056 has been marked as a duplicate of this bug. ***
Comment 13 Craig Andrews gentoo-dev 2020-08-02 01:21:50 UTC
*** Bug 735060 has been marked as a duplicate of this bug. ***