Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716970 - QA policy: Virtuals must not install any files
Summary: QA policy: Virtuals must not install any files
Status: RESOLVED FIXED
Alias: None
Product: Quality Assurance
Classification: Unclassified
Component: Policies (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard: vote [y/n/a]: 5/0/0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-10 18:06 UTC by Ulrich Müller
Modified: 2021-07-21 01:15 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
installed-files: Virtuals must not install any files. (0001-installed-files-Virtuals-must-not-install-any-files.patch,1.34 KB, patch)
2020-04-10 18:06 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2020-04-10 18:06:55 UTC
Created attachment 631990 [details, diff]
installed-files: Virtuals must not install any files.

Please vote on attached addition to the QA Policy Guide.
Comment 1 Ulrich Müller gentoo-dev 2020-04-10 18:08:42 UTC
I vote yes.
Comment 2 Michael Orlitzky gentoo-dev 2020-04-10 18:15:42 UTC
FWIW this is tacit per the PMS:

  A new-style virtual is a normal package in the virtual category which installs 
  no files and uses its dependency requirements to pull in a ‘provider’.
Comment 3 Andreas K. Hüttel archtester gentoo-dev 2020-04-10 18:19:22 UTC
I vote yes

But indeed this is redundant as it's also stated in PMS. So either a virtual is a special type of package (as per PMS), or it's a normal package with a special name, which gets special treatment per tree policy. What do we want?
Comment 4 Ulrich Müller gentoo-dev 2020-04-10 19:47:15 UTC
(In reply to Michael Orlitzky from comment #2)
> FWIW this is tacit per the PMS:
> 
>   A new-style virtual is a normal package in the virtual category which
>   installs no files and uses its dependency requirements to pull in a
>   ‘provider’.

I am aware of it. However, that text appears only in the Glossary, so arguably it isn't really part of the spec:
https://projects.gentoo.org/pms/7/pms.html#x1-15400015

Apart from this, and from the "Historical Curiosities" appendix referring to old-style virtuals, PMS doesn't impose any special rules for virtuals. So effectively it is a tree policy.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-11 06:01:01 UTC
Yar.

I think it doesn't belong in PMS.
Comment 6 David Seifert gentoo-dev 2020-04-11 11:12:00 UTC
Yes,

and no reason to put it in the spec.
Comment 7 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2020-04-11 13:33:03 UTC
I vote yes.
Comment 8 Larry the Git Cow gentoo-dev 2021-01-26 18:48:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/policy-guide.git/commit/?id=cb43291806dac6f2a8d26f2ef4a794b42e8c52a5

commit cb43291806dac6f2a8d26f2ef4a794b42e8c52a5
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2020-04-10 12:54:58 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2021-01-26 18:46:27 +0000

    installed-files: Virtuals must not install any files.
    
    Closes: https://bugs.gentoo.org/716970
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 installed-files.rst | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Comment 9 Ulrich Müller gentoo-dev 2021-01-26 18:48:46 UTC
Sorry for the delay, I had completely forgotten about this.
Comment 10 Ulrich Müller gentoo-dev 2021-01-26 18:54:02 UTC
And for the record, new-style virtuals are gone from PMS, except for a note in the appendix.

https://gitweb.gentoo.org/proj/pms.git/commit/?id=58d5831ef7cc673858ea85d54ff0693f6a2f9914

commit 58d5831ef7cc673858ea85d54ff0693f6a2f9914
Author: Ulrich Müller <ulm@gentoo.org>
Date:   Sat Apr 11 11:56:39 2020 +0200

    glossary.tex: Move explanation of new-style virtuals to the appendix.
    
    The term "new-style virtual" is not used in the spec, so we need not
    explain it in the glossary.
    
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>