Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716954 - net-misc/remmina build error with net-misc/freerdp-9999
Summary: net-misc/remmina build error with net-misc/freerdp-9999
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ben Kohler
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-10 15:11 UTC by Joakim Tjernlund
Modified: 2024-01-04 00:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2020-04-10 15:11:10 UTC
-- Checking for module 'freerdp2>=2.0.0'
--   No package 'freerdp2' found
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find FREERDP (missing: FREERDP_LIBRARY FREERDP_INCLUDE_DIR)
Call Stack (most recent call first):

This is because freerdp master now targets 3.0
Maybe have freerdp-9999 point to stable-2.0 branch instead?
Comment 1 Mike Gilbert gentoo-dev 2020-04-10 15:21:50 UTC
> Maybe have freerdp-9999 point to stable-2.0 branch instead?

No, I think it's more appropriate to have 9999 pointed at master. People using this version should expect things to break.

If you would find it valuable, I could add another live ebuild tracking the stable-2.0 branch.
Comment 2 Ben Kohler gentoo-dev 2020-04-10 15:24:15 UTC
In either case it seems like I should make remmina depend on <net-misc/freerdp-3 or so.  Agreed?

I assume your 2.0 branch live ebuild would be 2.9999 or 2.0.9999 or similar.
Comment 3 Mike Gilbert gentoo-dev 2020-04-10 15:29:25 UTC
(In reply to Ben Kohler from comment #2)
> In either case it seems like I should make remmina depend on
> <net-misc/freerdp-3 or so.  Agreed?

That sounds like a good idea.

> I assume your 2.0 branch live ebuild would be 2.9999 or 2.0.9999 or similar.

Right. I'm actually having that debate in my head right now, but it will certainly be 2.something.
Comment 4 Joakim Tjernlund 2020-04-10 16:59:20 UTC
(In reply to Mike Gilbert from comment #1)
> > Maybe have freerdp-9999 point to stable-2.0 branch instead?
> 
> No, I think it's more appropriate to have 9999 pointed at master. People
> using this version should expect things to break.
> 
> If you would find it valuable, I could add another live ebuild tracking the
> stable-2.0 branch.

Yes, an ebuild tracking the stable-2.0 branch would be much appreciated.
There is nothing looking for 3.0 now so current master will just break
everything.
Comment 5 Larry the Git Cow gentoo-dev 2020-04-10 18:38:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=580713b7be006c2f49fe21d7a093fb35ad035268

commit 580713b7be006c2f49fe21d7a093fb35ad035268
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2020-04-10 18:35:30 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2020-04-10 18:37:18 +0000

    net-misc/freerdp: add live ebuild for stable-2.0 branch
    
    Bug: https://bugs.gentoo.org/716954
    Package-Manager: Portage-2.3.96_p4, Repoman-2.3.22_p1
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 net-misc/freerdp/freerdp-2.9999.ebuild | 125 +++++++++++++++++++++++++++++++++
 net-misc/freerdp/freerdp-9999.ebuild   |  13 ++--
 2 files changed, 133 insertions(+), 5 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2020-04-10 19:56:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a361f08c9525cfbd6eccff7ca50c7b35a0c4b34

commit 2a361f08c9525cfbd6eccff7ca50c7b35a0c4b34
Author:     Ben Kohler <bkohler@gentoo.org>
AuthorDate: 2020-04-10 19:56:06 +0000
Commit:     Ben Kohler <bkohler@gentoo.org>
CommitDate: 2020-04-10 19:56:25 +0000

    net-misc/remmina: depend on <freerdp-3
    
    Closes: https://bugs.gentoo.org/716954
    Package-Manager: Portage-2.3.98, Repoman-2.3.22
    Signed-off-by: Ben Kohler <bkohler@gentoo.org>

 net-misc/remmina/{remmina-1.4.2.ebuild => remmina-1.4.2-r1.ebuild} | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Christian Bricart 2024-01-04 00:21:43 UTC
(just leaving the pending upstream MR here, that will add FreeRDP-3.0 support for info: https://gitlab.com/Remmina/Remmina/-/merge_requests/2554 )