Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716948 - dev-libs/hsa-amd-aqlprofile - Proprietary AQLPROFILE library for Radeon Open Compute
Summary: dev-libs/hsa-amd-aqlprofile - Proprietary AQLPROFILE library for Radeon Open ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-10 13:55 UTC by Dennis Schridde
Modified: 2022-06-22 13:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2020-04-10 13:55:47 UTC
When I run `clinfo` on my system, it mentions missing libraries:
```
LoadLib(libhsa-ext-finalize64.so.1) failed: libhsa-ext-finalize64.so.1: cannot open shared object file: No such file or directory
LoadLib(libhsa-amd-aqlprofile64.so) failed: libhsa-amd-aqlprofile64.so: cannot open shared object file: No such file or directory
```

According to an upstream bug report [1] `libhsa-amd-aqlprofile64.so` can be obtained from an upstream Debian package repository [2].  I was unable to find the source for it, though.  The package lists a homepage [3], but that does not exist anymore (404).

It is still unclear where to get `libhsa-ext-finalize64.so.1` from. [4]

[1]: https://github.com/RadeonOpenCompute/ROCR-Runtime/issues/89#issuecomment-612023688
[2]: https://repo.radeon.com/rocm/apt/debian/pool/main/h/
[3]: https://github.com/RadeonOpenCompute/HSA-AqlProfile-AMD-extension
[4]: https://github.com/RadeonOpenCompute/ROCR-Runtime/issues/89
Comment 1 Marek Szuba (RETIRED) archtester gentoo-dev 2020-04-20 21:50:47 UTC
For the record, this profiler has long since been deprecated in favour of RCP (https://github.com/GPUOpen-Tools/radeon_compute_profiler). Between that and it being proprietary, I would very much advise against adding it to the tree. And yes, candrews and I *will* eventually get to packaging RCP for Gentoo :-)

Regarding the messages (which according to both my experience and comments in the linked upstream issue are purely informational), add -DNDEBUG to CXXFLAGS before re-emerging dev-libs/rocr-runtime and they will stop. I'll discuss with candrews how to handle this flag properly in the future, on the off chance that someone MIGHT want to emerge this package in debug mode.
Comment 2 Dennis Schridde 2020-04-21 05:31:32 UTC
(In reply to Marek Szuba from comment #1)
> Regarding the messages (which according to both my experience and comments
> in the linked upstream issue are purely informational), add -DNDEBUG to
> CXXFLAGS before re-emerging dev-libs/rocr-runtime and they will stop.

https://github.com/RadeonOpenCompute/ROCR-Runtime/issues/89#issuecomment-615304124 suggests:
> > The warning you are seeing is emitted only in debug builds and is present as a notification of which optional extension libraries were not loaded.
> 
> Thanks for your explanation @skeelyamd! Running cmake with `-DCMAKE_BUILD_TYPE=Release` fixes the issue.

cmake.eclass says about the flag:
# @ECLASS-VARIABLE: CMAKE_BUILD_TYPE
# @DESCRIPTION:
# Set to override default CMAKE_BUILD_TYPE. Only useful for packages
# known to make use of "if (CMAKE_BUILD_TYPE MATCHES xxx)".
# If about to be set - needs to be set before invoking cmake_src_configure.
# You usually do *NOT* want nor need to set it as it pulls CMake default
# build-type specific compiler flags overriding make.conf.
: ${CMAKE_BUILD_TYPE:=Gentoo}

Thus I guess we need to append "Gentoo" to CMAKE_CONFIGURATION_TYPES and then add "-DNDEBUG" to CMAKE_C_FLAGS_GENTOO_INIT and CMAKE_CXX_FLAGS_GENTOO_INIT.
Comment 3 Dennis Schridde 2020-04-21 05:38:48 UTC
(In reply to Dennis Schridde from comment #2)
> Thus I guess we need to append "Gentoo" to CMAKE_CONFIGURATION_TYPES and
> then add "-DNDEBUG" to CMAKE_C_FLAGS_GENTOO_INIT and
> CMAKE_CXX_FLAGS_GENTOO_INIT.

P.S. This is my conclusion after looking at:
* /usr/share/cmake/Help/variable/CMAKE_CONFIGURATION_TYPES.rst
* /usr/share/cmake/Help/variable/CMAKE_BUILD_TYPE.rst
* /usr/share/cmake/Help/variable/CMAKE_LANG_FLAGS_CONFIG_INIT.rst
* /usr/share/cmake/Modules/CMakeInitializeConfigs.cmake
Comment 4 Larry the Git Cow gentoo-dev 2022-02-06 14:48:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d2b6d182c6d7945ec5166803ca071f640ad994b

commit 1d2b6d182c6d7945ec5166803ca071f640ad994b
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2022-02-06 14:45:05 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2022-02-06 14:48:15 +0000

    dev-libs/rocr-runtime: drop proprietary AQLProfile.
    
    Patch out the error messages.
    
    Closes: https://bugs.gentoo.org/716948
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 .../files/rocr-runtime-4.3.0_no-sqlprofiler.patch  | 29 ++++++++++++++++++++++
 dev-libs/rocr-runtime/rocr-runtime-4.3.0.ebuild    |  4 ++-
 2 files changed, 32 insertions(+), 1 deletion(-)
Comment 5 Andrei Slavoiu 2022-04-18 17:17:20 UTC
The patch that silences the error message got lost in upgrade. Maybe it could be readded with a comment why it's needed? Fixing the typo in the patch name might help with that.
Comment 6 Larry the Git Cow gentoo-dev 2022-06-13 12:00:56 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d4034da0890695292c0c2d24aba60446bcf8a465

commit d4034da0890695292c0c2d24aba60446bcf8a465
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2022-05-10 14:33:21 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2022-06-13 12:00:45 +0000

    dev-util/roctracer: compile tarcer_tool for rocprofiler
    
    - patch out loading libhsa-amd-aqlprofile64.so
    - Use `hipconfig -p` to determine HIP_PATH
    
    Bug: https://github.com/gentoo/gentoo/pull/25536
    Bug: https://bugs.gentoo.org/716948
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 dev-util/roctracer/Manifest                        |  2 ++
 .../files/roctracer-4.3.0-tracer_tool.patch        | 35 ++++++++++++++++++++++
 ...r-4.3.0-r1.ebuild => roctracer-4.3.0-r2.ebuild} | 17 +++++++----
 dev-util/roctracer/roctracer-5.0.2.ebuild          | 17 ++++++++---
 4 files changed, 61 insertions(+), 10 deletions(-)
Comment 7 Larry the Git Cow gentoo-dev 2022-06-22 13:21:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8478a19fa160b05830b88089ded071558c2b3cfa

commit 8478a19fa160b05830b88089ded071558c2b3cfa
Author:     Yiyang Wu <xgreenlandforwyy@gmail.com>
AuthorDate: 2022-06-22 12:50:52 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2022-06-22 13:21:46 +0000

    dev-libs/rocr-runtime: re-enable the cmake-install-dir.patch
    
    This partially reverts 1d2b6d182c6d7945ec5166803ca.
    
    Suggested-By: Shunsuke Shimizu, Patrice Levesque
    Closes: https://github.com/gentoo/gentoo/pull/26039
    Bug: https://bugs.gentoo.org/716948
    Closes: https://bugs.gentoo.org/832850
    Signed-off-by: Yiyang Wu <xgreenlandforwyy@gmail.com>
    Signed-off-by: Benda Xu <heroxbd@gentoo.org>

 ....0_no-sqlprofiler.patch => rocr-runtime-4.3.0_no-aqlprofiler.patch} | 0
 dev-libs/rocr-runtime/rocr-runtime-4.3.0.ebuild                        | 3 +--
 2 files changed, 1 insertion(+), 2 deletions(-)