Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716930 - dev-libs/rocr-runtime-3.3.0 - Remove IUSE=non-free
Summary: dev-libs/rocr-runtime-3.3.0 - Remove IUSE=non-free
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Craig Andrews
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-10 12:15 UTC by Dennis Schridde
Modified: 2020-08-25 21:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2020-04-10 12:15:06 UTC
Currently dev-libs/rocr-runtime-3.3.0 contains:
```
IUSE="non-free"

RDEPEND="${COMMON_DEPEND}
	non-free? ( dev-libs/hsa-ext-rocr )"
```

However, the build itself does not depend on USE=non-free.

Gentoo Dev Manual recommends:

>  The usage of a USE flag should not control runtime dependencies when the package does not link to it. Doing so will create extra configuration for the package and re-compilation for no underlying file change on disk. This should be avoided and instead can be conveyed to the user via post install messages if needed.
> (source: https://devmanual.gentoo.org/general-concepts/use-flags/#when-not-to-use-use-flags)

Thus I propose to remove IUSE=non-free and replace it with a `pkg_postinst()` function informing users to install dev-libs/hsa-ext-rocr if desired.
Comment 1 Larry the Git Cow gentoo-dev 2020-08-25 21:08:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a762bf47f145488ae284c1601e253320f336fb3d

commit a762bf47f145488ae284c1601e253320f336fb3d
Author:     Craig Andrews <candrews@gentoo.org>
AuthorDate: 2020-08-25 21:07:30 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2020-08-25 21:08:08 +0000

    dev-libs/rocr-runtime: Remove USE="non-free"
    
    Upstream no longer publishes the dev-libs/hsa-ext-rocr library.
    ROC has had open-source OpenCL image support since 3.3.
    
    Closes: https://bugs.gentoo.org/716930
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Craig Andrews <candrews@gentoo.org>

 dev-libs/rocr-runtime/metadata.xml              |  3 ---
 dev-libs/rocr-runtime/rocr-runtime-3.7.0.ebuild |  4 +---
 dev-libs/rocr-runtime/rocr-runtime-9999.ebuild  | 19 +++++++++++++++----
 3 files changed, 16 insertions(+), 10 deletions(-)