Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716844 - net-im/telegram-desktop should not depends on X11
Summary: net-im/telegram-desktop should not depends on X11
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-09 19:55 UTC by Yaroslav Isakov
Modified: 2020-04-20 18:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yaroslav Isakov 2020-04-09 19:55:01 UTC
Hello! I'm trying to drop X11 from my system, and I found that in it's code, there are no dependency on libX11. Also, they support both 'xcb' and 'wayland' QT platforms, so when I recompiled QT with "-X" useflag, and dropped this flag from telegram-desktop ebuild, I could compile and run telegram without any problems under wayland. Also, I cannot find any mention of libva in their code, so maybe this dep could be dropped as well.

So, my proposal is to at least add useflag X to ebuild of telegram-desktop
Comment 1 Yaroslav Isakov 2020-04-09 20:43:53 UTC
I've double-checked via code, and it looks like libX11 is needed only in two cases: if DESKTOP_APP_USE_PACKAGED=OFF, or if (DESKTOP_APP_USE_PACKAGED=ON and TDESKTOP_DISABLE_GTK_INTEGRATION=OFF). Ebuild is using DESKTOP_APP_USE_PACKAGED=ON, and ebuild is not using gtk3 integration anymore.
Comment 2 Georgy Yakovlev archtester gentoo-dev 2020-04-10 09:27:16 UTC
I think TDESKTOP_DISABLE_GTK_INTEGRATION=OFF was the default if not set explicitly, but can't check right now. I'll see what I can do here, I also did not like forcing libva and looks like we can just depend on ffmpeg and rely on vaapi flipped there.
Comment 3 Larry the Git Cow gentoo-dev 2020-04-20 17:59:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27066e9e536d11339d965c14e7a3cd4046edbd88

commit 27066e9e536d11339d965c14e7a3cd4046edbd88
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-04-20 17:16:05 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-04-20 17:59:14 +0000

    net-im/telegram-desktop: revbump 2.0.1, clarify dependencies
    
    rework deps a bit
    add py3.8
    split X and wayland
    
    Closes: https://bugs.gentoo.org/716844
    Closes: https://bugs.gentoo.org/715116
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 .../telegram-desktop-2.0.1-r1.ebuild               | 134 +++++++++++++++++++++
 1 file changed, 134 insertions(+)
Comment 4 Georgy Yakovlev archtester gentoo-dev 2020-04-20 18:01:00 UTC
please test and let me know, feel free to re-open the bug if there are still problems.

Generally it should pull X11 indirectly via one of the qt deps, only via USE=X