Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716818 - media-libs/zxing-cpp generates zxing.pc with an empty version string (PATCH)
Summary: media-libs/zxing-cpp generates zxing.pc with an empty version string (PATCH)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2020-04-09 16:32 UTC by cyrillic
Modified: 2020-04-09 21:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pkgversion.patch (pkgversion.patch,303 bytes, patch)
2020-04-09 16:33 UTC, cyrillic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cyrillic 2020-04-09 16:32:03 UTC
media-libs/zxing-cpp generates zxing.pc with an empty version string

Reproducible: Always

Actual Results:  
This is giving me configure problems with gstreamer like this :

...
Run-time dependency wayland-server found: YES 1.18.90
Run-time dependency x265 found: YES 3.2.1
Dependency zxing found: NO unknown version, but need: ['>= 0.9']
Run-time dependency zxing found: NO (tried cmake)

ext/zxing/meson.build:5:0: ERROR: Unknown version of dependency 'zxing', but need ['>= 0.9'].
Comment 1 cyrillic 2020-04-09 16:33:18 UTC
Created attachment 631644 [details, diff]
pkgversion.patch

This patch fixes the problem.
Comment 2 Andreas Sturmlechner gentoo-dev 2020-04-09 16:42:28 UTC
Thanks for catching that.

...but then they forgot to bump their version it seems and the file contains 1.0.7...
Comment 3 Andreas Sturmlechner gentoo-dev 2020-04-09 17:15:47 UTC
I don't see it filed upstream yet. Will you create a pull request there?
Comment 4 Larry the Git Cow gentoo-dev 2020-04-09 21:36:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f9d4418788a98c6acd9b904cb806767487d55776

commit f9d4418788a98c6acd9b904cb806767487d55776
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-04-09 17:17:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-04-09 21:36:22 +0000

    media-libs/zxing-cpp: Fix pkgconfig version
    
    Thanks-to: cyrillic <cyrilmaley@hotmail.com>
    Closes: https://bugs.gentoo.org/716818
    Package-Manager: Portage-2.3.98, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../zxing-cpp/files/zxing-cpp-1.0.8-pkgconfig.patch     | 10 ++++++++++
 media-libs/zxing-cpp/zxing-cpp-1.0.8-r1.ebuild          | 17 +++++++++++++++++
 2 files changed, 27 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=656577c775a39dc67e2514ada4d4b4f64683463d

commit 656577c775a39dc67e2514ada4d4b4f64683463d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-04-09 17:20:23 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-04-09 21:36:23 +0000

    media-libs/zxing-cpp: Fix actual version as well
    
    Bug: https://bugs.gentoo.org/716818
    Package-Manager: Portage-2.3.98, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../zxing-cpp/files/zxing-cpp-1.0.8-version.patch  | 22 ++++++++++++++++++++++
 media-libs/zxing-cpp/zxing-cpp-1.0.8-r1.ebuild     |  5 ++++-
 2 files changed, 26 insertions(+), 1 deletion(-)