Created attachment 630968 [details] Ebuild for openttd-1.10.0 Hello, OpenTTD version 1.10.0 has been released. Proposed ebuild attached. Change - removed the --without-timidity as it fails to compile with it. Lubos
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck * Please remove obsolete lines * please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/) * Please add the missing "die" in the rm line * A bot can look for additional mistakes, if you upload a PR via github
Thanks, I will fix and create PR
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7b6c0f34a95ebbe648d584b514463ecdc969c97 commit e7b6c0f34a95ebbe648d584b514463ecdc969c97 Author: Lubos Kolouch <lubos@kolouch.net> AuthorDate: 2020-04-07 19:21:29 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2020-04-14 21:58:48 +0000 games-simulation/openttd: New version 1.10.0 Closes: https://bugs.gentoo.org/716528 Closes: https://github.com/gentoo/gentoo/pull/15260 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: James Le Cuirot <chewi@gentoo.org> games-simulation/openttd/Manifest | 1 + games-simulation/openttd/openttd-1.10.0.ebuild | 180 +++++++++++++++++++++++++ games-simulation/openttd/openttd-9999.ebuild | 6 +- 3 files changed, 184 insertions(+), 3 deletions(-)
The SDL dependency in the ebuild needs to change, openttd requires libsdl2 now. The configure stage fails when libsdl2 is not installed. I've replaced the libsdl dep with libsdl2 in the ebuild, uninstalled libsdl and then installed openttd again, pulling in libsdl2. It builds and runs fine, then. I hope it's fine to post here instead of starting a fresh bug. Thanks.
(In reply to Andre Müller from comment #4) > The SDL dependency in the ebuild needs to change, > openttd requires libsdl2 now. > > The configure stage fails when libsdl2 is not installed. > > I've replaced the libsdl dep with libsdl2 in the ebuild, > uninstalled libsdl and then installed openttd again, > pulling in libsdl2. It builds and runs fine, then. > > I hope it's fine to post here instead of starting a fresh bug. > Thanks. Let me fix it
Created attachment 633272 [details] Ebuild with sdl2 to check
(In reply to Lubos Kolouch from comment #5) > (In reply to Andre Müller from comment #4) > > The SDL dependency in the ebuild needs to change, > > openttd requires libsdl2 now. > > > > The configure stage fails when libsdl2 is not installed. > > > > I've replaced the libsdl dep with libsdl2 in the ebuild, > > uninstalled libsdl and then installed openttd again, > > pulling in libsdl2. It builds and runs fine, then. > > > > I hope it's fine to post here instead of starting a fresh bug. > > Thanks. > > Let me fix it Andre, thanks for reporting again - can you check attached ebuild if it works for you? thanks...
The attached ebuild is identical to the one I created and tested locally, so yes, I can confirm it works. Thanks.
(In reply to Andre Müller from comment #8) > The attached ebuild is identical to the one I created and tested locally, so > yes, I can confirm it works. Thanks. Thanks, I created new PR for new version 1.10.1 that has been release in the meantime, with your SDL2 fix!
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7fd6b71cb7c2fc49a0e9cbf5fc89c41513f09356 commit 7fd6b71cb7c2fc49a0e9cbf5fc89c41513f09356 Author: James Le Cuirot <chewi@gentoo.org> AuthorDate: 2020-04-16 20:36:34 +0000 Commit: James Le Cuirot <chewi@gentoo.org> CommitDate: 2020-04-16 20:43:55 +0000 games-simulation/openttd: Fix dependencies and CC/CXX Bug: https://bugs.gentoo.org/716528 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: James Le Cuirot <chewi@gentoo.org> .../{openttd-1.10.0.ebuild => openttd-1.10.0-r1.ebuild} | 11 +++++++---- games-simulation/openttd/openttd-9999.ebuild | 11 +++++++---- 2 files changed, 14 insertions(+), 8 deletions(-)
