Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 716512 - media-tv/xmltv-0.6.1 version bump
Summary: media-tv/xmltv-0.6.1 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: EBUILD, PullRequest
Depends on:
Blocks:
 
Reported: 2020-04-07 03:59 UTC by Preston Crow
Modified: 2020-05-10 06:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xmltv-0.6.1.ebuild (xmltv-0.6.1.ebuild,5.26 KB, text/plain)
2020-04-07 04:01 UTC, Preston Crow
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Preston Crow 2020-04-07 03:59:47 UTC
Version 0.5.70 in portage doesn't work with the latest release of mythtv, or at least enough options have changed that it is no longer compatible with the configuration instructions.

Reproducible: Always




The ebuild needs some tweaking to pull from github instead of sourceforge, as well as additional perl module dependencies.
Comment 1 Preston Crow 2020-04-07 04:01:21 UTC
Created attachment 630922 [details]
xmltv-0.6.1.ebuild

This is the works-for-me ebuild for the latest version.  The perl modules that I added as dependencies are probably only with the zz-sdjson use flag, but I'm not really certain.
Comment 2 Wilson M. Michaels 2020-04-07 17:41:21 UTC
(In reply to Preston Crow from comment #1)
> Created attachment 630922 [details]
> xmltv-0.6.1.ebuild
> 
> This is the works-for-me ebuild for the latest version.  The perl modules
> that I added as dependencies are probably only with the zz-sdjson use flag,
> but I'm not really certain.

Yes, the README lists the various dependencies thus the perl modules added, 'dev-perl/DateTime-Format-SQLite' and 'dev-perl/LWP-UserAgent-Determined', should be moved to the conditional 'zz-sdjson?' dependency. 

They are not keyworded for all keywords in the xmltv-0.6.1.ebuild.
This is what makes 'repoman -dx full' unhappy.

Since I am maintaining mythtv ebuild's, I'll see about maintaining this ebuild too.
Comment 3 Jonas Stein gentoo-dev 2020-04-07 20:14:49 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

• Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck
• We always try to use the latest EAPI, please bump to EAPI=7
• Please remove obsolete lines
• KEYWORDS need ~ after a version bump run ekeyword ~all YOUREBUILD
• A bot can look for additional mistakes, if you upload a PR via github
Comment 4 Wilson M. Michaels 2020-04-07 21:27:18 UTC
I pushed my work to xmltv branch in my overlay tree:

https://github.com/thebitpit/gentoo/tree/xmltv

Removed ppc and arm KEYWORDS because some newly required perl modules were only for amd64 and x86. repoman gets angry about that.

Modified to use newer version listed in README file. Compiles and installs, but I have not tested it yet. 

Will look at it with rested eyes tomorrow and create a Pull Request when it is ready for Proxy Maintainer Group's review.
Comment 5 Larry the Git Cow gentoo-dev 2020-05-04 16:25:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6a3e6d5426597d353dd6c57b1f6649e654d2e739

commit 6a3e6d5426597d353dd6c57b1f6649e654d2e739
Author:     Wilson Michaels <thebitpit@earthlink.net>
AuthorDate: 2020-04-07 20:42:09 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2020-05-04 16:24:46 +0000

    media-tv/xmltv: Bump version 0.6.1
    
    Bug: https://bugs.gentoo.org/716512
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Wilson Michaels <thebitpit@earthlink.net>
    Closes: https://github.com/gentoo/gentoo/pull/15275
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-tv/xmltv/Manifest           |   1 +
 media-tv/xmltv/metadata.xml       |  21 ++-
 media-tv/xmltv/xmltv-0.6.1.ebuild | 285 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 302 insertions(+), 5 deletions(-)